Allow JSON Response to Return Boolean false Value
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors add @DomParfitt for code and test |
|
I've put up a pull request to add @DomParfitt! 🎉 |
|
@DomParfitt your fix is in |
This was referenced Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the implementation will fail to validate responses that return a simple JSON boolean value in the case where the value returned is
false.This is due to a check in the response validator to see if the body of a response exists and returns a
500response if it does not, which currently uses a shorthand check for the existence of the response body. As a result if the response body is set to a simplefalsevalue it is treated as if the body does not exist.