Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) #415 Cannot read property 'push' of undefined bug #420

Merged
merged 1 commit into from Oct 26, 2020
Merged

(fix) #415 Cannot read property 'push' of undefined bug #420

merged 1 commit into from Oct 26, 2020

Conversation

ex1st
Copy link
Contributor

@ex1st ex1st commented Oct 26, 2020 •
edited

Hi @cdimascio, I've added a test for #415, but accidentally closed #419. Sorry.

cdimascio
cdimascio approved these changes Oct 26, 2020
View reviewed changes
Copy link
Owner

@cdimascio cdimascio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ex1st, thanks a lot for your work!

@cdimascio
Copy link
Owner

@all-contributors add @ex1st for code and test

@allcontributors allcontributors bot mentioned this pull request Oct 26, 2020
Merged
@allcontributors
Copy link
Contributor

@cdimascio

I've put up a pull request to add @ex1st! 🎉

@cdimascio cdimascio merged commit e113eed into cdimascio:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdimascio cdimascio cdimascio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ex1st @cdimascio