Publish generated source maps to NPM #568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
πββοΈ This PR removes the
*.map
rule from.npmignore
with the intent that source maps are published in future NPM releases.I somewhat-often find myself setting breakpoints in dependencies during development to either be able to trace what seems like a bug or simply to figure out how a dependency is working in order to be able to contribute. Today, when I launch my debugger, I get a slew of "errors" complaining about not being able to find source maps for this package:
This repeats for basically every file in
dist
.There may be more to this PR than simply removing the
*.map
rule, but I would propose that source maps should be distributed as part of the NPM release process and this seemed like the first step. As far as I can tell, thetsconfig
is already configured to generate source maps.Please let me know if there's further work to be done here and I'll be happy to help!