Normalize request body ContentTypes #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayvincent2
force-pushed
the
bugfix/content-type-parameters
branch
from
828cd1e
to
7250470
Compare
|
Has anybody had a chance to review this? |
cdimascio
reviewed
Dec 1, 2023
| } | ||
| types.push(new ContentType(this.mediaType)); | ||
|
|
||
| if (!this.parameters['charset']) { |
There was a problem hiding this comment.
Looks like this will add utf-8 as an equivalent content type 👍
There was a problem hiding this comment.
Glad you noticed. I saw that you were accounting for utf-8 and wanted to make sure I maintained that.
src/middlewares/util.ts
Outdated
| return types; | ||
| } | ||
|
|
||
| public normalize(excludeParams: string[] = ['boundary']) { |
There was a problem hiding this comment.
Nit: add the method’s return type
Getting to this now. Looks good. Thank you! One minor review nit |
rayvincent2
force-pushed
the
bugfix/content-type-parameters
branch
from
01a3502
to
169ce03
Compare
Thanks for the review! I went ahead and made the update, rebased, and squashed. It's ready for another look. |
cdimascio
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #862
First I tackled ensuring that any ContentType type could be normalized so we could perform easy comparisons between what an HTTP request may send vs what the openapi document is expecting. By normalizing as well, I was able to easily ensure that cache keys for validators don't have any conflicts.
Tests have been added to showcase the working solution.