Pass-through HttpError caught in multipart handler #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consumers of express-openapi-validator have access to the custom error types via exported object: error (e.g. error.BadRequest). - If the multipart handler throws, for example from the multer storage engine, check whether the err instance is already an HttpError. If so, it can be passed-through as is. This is mostly useful for setting the HTTP status code.
|
@cdimascio, for your consideration. |
|
@cdimascio - Any initial thoughts on whether you're on-board with this idea? I'd like to end use of my fork and whether this PR is accepted or not will dictate whether I need to find an alternative approach to propagate HTTP status codes from the multer storage engine to the final HTTP response. |
cdimascio
approved these changes
Nov 18, 2023
|
Looks good. Thank you. Will roll a new version with this soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error.BadRequest).errinstance is already anHttpError. If so, it can be passed-through as is. This is mostly useful for setting the HTTP status code.