Remove read only and write only fields #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- requests if ``validateRequest.removeAdditional`` configuration equals ``true`` or ```'all'`` or ``'failing'`` - responses if ``validateResponse.removeAdditional`` configuration equals ``true`` or ```'all'`` or ``'failing'`` No changes if ``validateRequest = true``, ``validateResponse = true``, ``validateRequest.removeAdditional : false``, ``validateResponse.removeAdditional : false`` Unit tests added to check the behaviour with removeAdditional : true. Fields removed and no error in response.
|
Fyi. Doc is now located here https://cdimascio.github.io/express-openapi-validator-documentation But repo here: https://github.com/cdimascio/express-openapi-validator-documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To meet the requirements of ticket #627, the following is proposed:
validateRequest.removeAdditionalis equal totrueor'allor'failingthen the fields received in request which are noted asreadonlyare removed before entering the routevalidateResponse.removeAdditionalis equal totrueorallorfailingthen the writeonly fields present in the response object are removed from the return flow before sending the response to the client.ajv/index.ts had been modified to do this behaviour.
2 unit tests had been created in order to check the behaviour when
removeAdditional : truePrevious unit tests still works as before.