-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-step reaction SMILES? #33
Comments
Would be nice but a bespoke format/extension which I'm not really a fan off. Fundamentally CDK data structures make this tricky (more structures needed) and it would be always be limited by the URL length.... Maybe one day but beyond something quick and dirty fix it's challenging |
Thanks! Hmm yes I suspected it may involve something beyond a quick fix ... |
This looks awesome! It hasn't filtered through yet to CDK Depict tho, right? We're using CDK Depict to curate Emma P's ShinyTPs work and multistep reactions are in our future perspectives for sure, this is very cool to see! |
No I submitted the PR yesterday, which examples don't work. This examples works fine on the branch:
The "CF2 Loss" is probably better as a title/condition. Space is not normally allowed in atom symbols :-). for (IReaction reaction : reactionSet.reactions()) {
reaction.setProperty(CDKConstants.REACTION_CONDITIONS, "CF2 Loss");
} |
Ignore the I-1, I-2, I-3 I was just playing around with compound naming. |
I just tried it directly on the website copy pasting the SMILES from your issues cos I was curious... |
Yes as I said, it's not merged into CDK yet so won't be on the production website for sometime. Was just letting you know this was in the works. |
Was very happy to see that it's in the works! ;-) |
Not sure if this is feasible ... but wanted to ask ;-)
The reaction SMILES functionality is awesome ... any chance we can deal with more steps?
The top three of these work ... the bottom one is invalid ... but would represent the flow of the top three.
Top two: individual steps. Third: a "two step" reaction that works ... Fourth: nice to have but invalid.
If it's already possible and I just got the syntax wrong, I'm all ears!
The text was updated successfully, but these errors were encountered: