Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm releases failing to generate provenance (#3800) #3802

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

cdk8s-automation
Copy link
Contributor

Backport

This will backport the following commits from k8s-28/main to k8s-27/main:

Questions ?

Please refer to the Backport tool documentation

We are [seeing](https://github.com/cdk8s-team/cdk8s-plus/actions/runs/8081657712/job/22080844284) the following error in NPM releases:

```console
npm ERR! Can't generate provenance for new or private package, you must set `access` to public.
```

As of Feb 14, projen [has started](projen/projen#3330) [generating provenance statements](https://docs.npmjs.com/generating-provenance-statements) for NPM releases (on by default for public packages).
It is not clear why we are seeing the failure above because `access` should be `public` by default for public packages.
My suspicion is that for the very first version of a package, `access` must be explicitly set. Trying this out.

(cherry picked from commit 119b5d4)
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@cdk8s-automation cdk8s-automation added the auto-approve Pull requests that should be auto approved label Feb 28, 2024
@mergify mergify bot merged commit 77e37b3 into k8s-27/main Feb 28, 2024
16 checks passed
@mergify mergify bot deleted the backport/k8s-27/main/pr-3800 branch February 28, 2024 17:47
@cdk8s-automation
Copy link
Contributor Author

⚪ Backport skipped

The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.

Manual backport

To create the backport manually run:

backport --pr 3802

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-approve Pull requests that should be auto approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants