Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pod, workload): scheduling strategy (affinity, tolerations, nodeName) #684

Merged
merged 54 commits into from May 21, 2022
Merged

feat(pod, workload): scheduling strategy (affinity, tolerations, nodeName) #684

merged 54 commits into from May 21, 2022

Conversation

iliapolo
Copy link
Member

@iliapolo iliapolo commented May 4, 2022 •
edited

Docs are here: cdk8s-team/cdk8s#911

A few notes:

  • The API doesn't use the terminology used by the k8s properties. Instead, it uses terminology from the Kubernetes docs, in an attempt to more clearly convey the intent of these capabilities. Would love input on this choice.
  • The API isn't exposed as constructor properties. I felt the semantic post-instantiation methods are way better at conveying the intent in this case. We can definitely add it though is there will be demand.

Resolves #31
Resolves #377
Resolves #360
Resolves #689

iliapolo added 20 commits May 1, 2022 13:00
@iliapolo
mid work
37f5e5b 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
node affinity
954611c 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
pod affinity and anti affinity
208cd1c 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
mid work
f8d7b48 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
add namespace list
4a053f6 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
mid work
f1abe5d 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
major refactor
06384c9 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
4b1ef98 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
cae43c2 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
a5b470d 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
18d49fe 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more refactgor
6a2e89c 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
a40fce6 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
bfac90e 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup
799dabb 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
assign a node by name
55b6845 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
type safer API
b29bc60 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
tests
865fa85 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
cleanup synth result for affinity
5603e0e 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
refactor
dd29893 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo iliapolo mentioned this pull request May 6, 2022
Merged
@iliapolo iliapolo requested a review from Chriscbr May 6, 2022 19:07
@iliapolo
naming
d1bb774 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo iliapolo marked this pull request as ready for review May 6, 2022 19:07
@iliapolo
new toleration API
a78d740 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
rename topologyKey to topology
14c7501 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
network policy
0b7018c 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Merge branch 'k8s-22/main' into epolon/node-and-pod-affinity
a108e1d 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
tests
a77c0dd 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
new api
0eaa958 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more tests
ea2b03e 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more tests
42cebaa 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more tests
cd2fec6 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more tests
26fc405 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
rename
4929604 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
remove connections code
d83c3b6 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
more docs
eb0be18 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
review comments
8563237 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Merge branch 'k8s-22/main' into epolon/node-and-pod-affinity
f8ffd24
@iliapolo iliapolo requested a review from Chriscbr May 14, 2022 19:34
Chriscbr
Chriscbr reviewed May 17, 2022
View reviewed changes
test/namespace.test.ts Show resolved Hide resolved
src/namespace.ts Outdated Show resolved Hide resolved
src/pod.ts Outdated Show resolved Hide resolved
@iliapolo
Merge branch 'k8s-22/main' into epolon/node-and-pod-affinity
bbb886b 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
change namespaces selection api
bb1c6c8 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
tests
adddfbf 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
tests
605194a 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
docstrings
0f9faf6 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Merge branch 'k8s-22/main' into epolon/node-and-pod-affinity
5a0365f 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
fix jsii compliance
dc68f8a 
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Merge branch 'k8s-22/main' into epolon/node-and-pod-affinity
3277797
@iliapolo iliapolo merged commit 6d02852 into k8s-22/main May 21, 2022
@iliapolo iliapolo deleted the epolon/node-and-pod-affinity branch May 21, 2022 22:12
cdk8s-automation pushed a commit that referenced this pull request May 21, 2022
@iliapolo
feat(pod, workload): scheduling strategy (affinity, tolerations, …
b36e715 
…`nodeName`) (#684)

(cherry picked from commit 6d02852)
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@cdk8s-automation cdk8s-automation mentioned this pull request May 21, 2022
Merged
cdk8s-automation pushed a commit that referenced this pull request May 21, 2022
@iliapolo
feat(pod, workload): scheduling strategy (affinity, tolerations, …
2237903 
…`nodeName`) (#684)

(cherry picked from commit 6d02852)
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@cdk8s-automation cdk8s-automation mentioned this pull request May 21, 2022
Closed
@cdk8s-automation
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ k8s-21/main
✅ k8s-20/main

Questions ?

Please refer to the Backport tool documentation

mergify bot pushed a commit that referenced this pull request May 21, 2022
@cdk8s-automation
feat(pod, workload): scheduling strategy (affinity, tolerations, …
d53882f 
…`nodeName`) (#684) (#730)

# Backport

This will backport the following commits from `k8s-22/main` to `k8s-21/main`:
 - [feat(pod, workload): scheduling strategy (`affinity`, `tolerations`, `nodeName`) (#684)](#684)



### Questions ?
Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
mergify bot pushed a commit to cdk8s-team/cdk8s that referenced this pull request May 22, 2022
@iliapolo
chore: docs for scheduling (#911)
3f6a978 
Docs for cdk8s-team/cdk8s-plus#684 (should be merged after)

Signed-off-by: iliapolo <epolon@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chriscbr Chriscbr Chriscbr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@iliapolo @cdk8s-automation @Chriscbr