feat: deprecate important property in favor of addToSummaryDashboard in CustomMetricGroup
#271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glyphack
changed the title
echeung-amzn
requested changes
Nov 14, 2022
…n CustomMeticGroup Resolves cdklabs#242 To keep the add to summary naming consistent the new property has been added to CustomMetricGroup.
echeung-amzn
approved these changes
Nov 15, 2022
echeung-amzn
changed the title
important property in favor of addToSummaryDashboard in CustomMetricGroup
echeung-amzn
changed the title
important property in favor of addToSummaryDashboard in CustomMetricGroupimportant property in favor of addToSummaryDashboard in CustomMetricGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #242
To keep the add to summary naming consistent the new property has been added to CustomMetricGroup.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license