Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdktf-snowflake takes hangs UI when loaded #703

Open
eladb opened this issue Nov 18, 2021 · 5 comments
Open

cdktf-snowflake takes hangs UI when loaded #703

eladb opened this issue Nov 18, 2021 · 5 comments
Labels
bug Something isn't working priority/p3 We will be very happy to implement it but nothing will happen if we don't

Comments

@eladb
Copy link
Contributor

eladb commented Nov 18, 2021

Page takes about 20s to load and during that time UI is blocked.

https://constructs.dev/packages/cdktf-snowflake/v/0.0.4?lang=typescript

@eladb
Copy link
Contributor Author

eladb commented Nov 18, 2021

The hot path is markdown rendering and it is caused by the fact that this module has a huge README. They basically generate the API reference and plug it into the README.

https://github.com/bcgalvin/cdktf-dbt-snowflake/blob/main/README.md

@eladb
Copy link
Contributor Author

eladb commented Nov 18, 2021

We could add some protection against huge README files and basically just indicate that the README is too large to render or something like that.

@addihorowitz @gabewomble any thoughts?

@gabewomble
Copy link
Contributor

This would take us full circle! We used to have a protection against readme's greater than a megabyte in size. We removed that when we started breaking apart the API reference, but it looks like in this case, the README includes a massive api reference along with the generated API reference

@github-actions
Copy link
Contributor

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Jan 18, 2022
@Chriscbr Chriscbr removed the stale label Jan 18, 2022
@Chriscbr
Copy link
Contributor

Mmm I'm wondering if it would be okay if we just only applied the size limit protection against the "README" section of the markdown file, and not bothering checking against the API reference section of the markdown file (since we're currently OK with that section being large).

@Chriscbr Chriscbr added bug Something isn't working priority/p3 We will be very happy to implement it but nothing will happen if we don't labels Jan 18, 2022
@addihorowitz addihorowitz added this to Backlog 🗄 in Construct Hub Post GA via automation Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/p3 We will be very happy to implement it but nothing will happen if we don't
Projects
Development

No branches or pull requests

3 participants