importer replaced "filename" with README

[glensc]

see cdnjs/cdnjs#6418
more specifically cdnjs/cdnjs#6418 (comment)

i ran importer (5e4f91a):

1. cdnjs-importer -p /home/users/glen/scm/cdnjs/cdnjs -g https://github.com/glensc/jquery.tiptip

my origin url had .js "filename" in package.json file: https://github.com/glensc/jquery.tiptip/blob/00ad42ba1296e94fa0f74e91f4fa328acf6b4635/package.json#L17

but importer created commit where it "filename" was replaced with "README.txt"

[IonicaBizau]

Thanks for heads-up, @glensc!

I think the importer should take the existing filename (if exists) and default to a smart one (if a filename field is not there).

[glensc]

well, the filename specified (jquery.tipTip.minified.js) exists in the repo:

https://github.com/glensc/jquery.tiptip/tree/00ad42ba1296e94fa0f74e91f4fa328acf6b4635

[IonicaBizau]

@glensc Exactly! Currently, this is not supported (the importer just overrides the filename field). It should be implemented. 😄

[glensc]

it also seems to disregard any "npm" keywords and overwrite with it's own values:
https://github.com/glensc/class.js/blob/06360245bf90e913f83f6db220f67e6362394e41/package.json

i wrote there:

  "filename": "node.class.js",
  "npmName": "class.js",
  "npmFileMap": [
    {
      "basePath": "",
      "files": [
        "*.js"
      ]
    }
  ]

but importer overwrote as:

  "filename": "/build.js",
  "npmName": "class.js",
  "npmFileMap": [
    {
      "basePath": "/build",
      "files": [
        "**/*"
      ]
    }
  ]

and imported all wrong files by it's config (unwanted stuff from build/**)

altho i don't know what cdnjs-importer is supposed to do, but it feels wrong to me!

[IonicaBizau]

There are few fields that are overridden. Instead of overriding we should default to these, I think. ❇️

[glensc]

the tool seems useless or i'm too stupid to use it? seems it flattens whole repo content and then ends up getting stuck.

what i did, was cloning origin repo https://github.com/arturadib/agility
and adding package.json to it glensc/agility@b17466f

and then running importer with -g to the fork:

$ cdnjs-importer/bin/cdnjs-importer -p ~/cdn-js -g https://github.com/glensc/agility
info  Pulling from origin.
info  Cloning https://github.com/glensc/agility into /tmp/tmp-23653zPxM5KC6WrUt
info  Set the source path: /
info  Creating the version directory: /home/glen/scm/cdn-jsajax/libs/agility/0.1.3
info  Getting the library files.
info  Checking if autoupdate config exists.
info  Writing the package.json file in /home/glen/scm/cdn-jsajax/libs/agility
info  Copying the library files
error Failed to copy the library files: ,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,Error: EEXIST: file already exists, mkdir '/home/glen/scm/cdn-jsajax/libs/agility/0.1.3/Preview',,,,,,,,,Error: EEXIST: file already exists, symlink '../../agility.js' -> '/home/glen/scm/cdn-jsajax/libs/agility/0.1.3/agility.js',,,,,,,,,
error ,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,Error: EEXIST: file already exists, mkdir '/home/glen/scm/cdn-jsajax/libs/agility/0.1.3/Preview',,,,,,,,,Error: EEXIST: file already exists, symlink '../../agility.js' -> '/home/glen/scm/cdn-jsajax/libs/agility/0.1.3/agility.js',,,,,,,,,
$ ls -l /home/glen/scm/cdn-jsajax/libs/agility/0.1.3/
total 1.2M
drwxrwxr-x 2 glen glen   23 jaan  25 18:51 123/
drwxrwxr-x 2 glen glen   58 jaan  25 18:51 agility-start/
drwxrwxr-x 3 glen glen   19 jaan  25 18:51 api/
drwxrwxr-x 6 glen glen 4.0K jaan  25 18:51 docs/
drwxrwxr-x 2 glen glen   63 jaan  25 18:51 gallery/
drwxrwxr-x 4 glen glen   53 jaan  25 18:51 logo-arrows.artx/
drwxrwxr-x 3 glen glen   37 jaan  25 18:51 logo.artx/
drwxrwxr-x 4 glen glen  122 jaan  25 18:51 media/
drwxrwxr-x 3 glen glen   33 jaan  25 18:51 people/
drwxrwxr-x 2 glen glen   24 jaan  25 18:51 Preview/
drwxrwxr-x 2 glen glen 4.0K jaan  25 18:51 public/
drwxrwxr-x 2 glen glen   24 jaan  25 18:51 QuickLook/
drwxrwxr-x 3 glen glen   87 jaan  25 18:51 test/
-rw-rw-r-- 1 glen glen  40K jaan  25 18:51 agility.js
-rw-rw-r-- 1 glen glen  18K jaan  25 18:51 agility.min.js
-rw-rw-r-- 1 glen glen 5.7K jaan  25 18:51 agility-start.zip
-rw-rw-r-- 1 glen glen  76K jaan  25 18:51 architecture.graffle
-rw-rw-r-- 1 glen glen  26K jaan  25 18:51 architecture.png
-rw-rw-r-- 1 glen glen  913 jaan  25 18:51 ChangeLog
-rw-rw-r-- 1 glen glen 122K jaan  25 18:51 cheaphotels.png
-rw-rw-r-- 1 glen glen   15 jaan  25 18:51 CNAME
-rw-rw-r-- 1 glen glen 109K jaan  25 18:51 container.graffle
-rw-rw-r-- 1 glen glen  32K jaan  25 18:51 container.png
-rw-rw-r-- 1 glen glen  49K jaan  25 18:51 core.js
-rw-rw-r-- 1 glen glen 1.1K jaan  25 18:51 core_only.html
-rw-rw-r-- 1 glen glen  371 jaan  25 18:51 demo.html
-rw-rw-r-- 1 glen glen 5.9K jaan  25 18:51 _docs.html
-rw-rw-r-- 1 glen glen  82K jaan  25 18:51 docs.html
-rw-rw-r-- 1 glen glen  36K jaan  25 18:51 _docs.md
-rw-rw-r-- 1 glen glen 8.7K jaan  25 18:51 doc.thread
-rw-rw-r-- 1 glen glen 1.2K jaan  25 18:51 favicon.ico
-rw-rw-r-- 1 glen glen 6.3K jaan  25 18:51 favicon.png
-rw-rw-r-- 1 glen glen 3.5K jaan  25 18:51 _gallery.html
-rw-rw-r-- 1 glen glen 4.3K jaan  25 18:51 gallery.html
-rw-rw-r-- 1 glen glen  744 jaan  25 18:51 _gallery.md
-rw-rw-r-- 1 glen glen 4.3K jaan  25 18:51 highlight.css
-rw-rw-r-- 1 glen glen 6.8K jaan  25 18:51 _index.html
-rw-rw-r-- 1 glen glen  34K jaan  25 18:51 index.html
-rw-rw-r-- 1 glen glen  11K jaan  25 18:51 _index.md
-rw-rw-r-- 1 glen glen 9.3K jaan  25 18:51 jquery.simplemodal.1.4.1.min.js
-rw-rw-r-- 1 glen glen 133K jaan  25 18:51 jshint.js
-rw-rw-r-- 1 glen glen 1.1K jaan  25 18:51 LICENSE
-rw-rw-r-- 1 glen glen  171 jaan  25 18:51 LICENSE_HEADER
-rw-rw-r-- 1 glen glen 8.3K jaan  25 18:51 logo-arrows-128.png
-rw-rw-r-- 1 glen glen  13K jaan  25 18:51 logo.png
-rw-rw-r-- 1 glen glen  789 jaan  25 18:51 main.js
-rw-rw-r-- 1 glen glen 1.1K jaan  25 18:51 Makefile
-rw-rw-r-- 1 glen glen  75K jaan  25 18:51 opdots.png
-rw-rw-r-- 1 glen glen  324 jaan  25 18:51 package.json
-rw-rw-r-- 1 glen glen 4.4K jaan  25 18:51 persist.js
-rw-rw-r-- 1 glen glen  684 jaan  25 18:51 playground.html
-rw-rw-r-- 1 glen glen 2.5K jaan  25 18:51 Preview.pdf
-rw-rw-r-- 1 glen glen  11K jaan  25 18:51 preview.png
-rw-rw-r-- 1 glen glen 4.5K jaan  25 18:51 qunit.css
-rw-rw-r-- 1 glen glen  38K jaan  25 18:51 qunit.js
-rw-rw-r-- 1 glen glen  576 jaan  25 18:51 README.md
-rw-rw-r-- 1 glen glen 1.5K jaan  25 18:51 server.js
-rw-rw-r-- 1 glen glen  48K jaan  25 18:51 thewall.png
-rw-rw-r-- 1 glen glen   20 jaan  25 18:51 VERSION

does it matter that the package.json is on master, i.e absent on 0.1.3 tag?

[IonicaBizau]

@glensc I wrote this thingy last year and I'm not sure how stable it is with the latest changes, but feel free to report any little issue and hopefully someone will fix them.

[glensc]

created new issue, but i'm not sure what the tool is supposed to do, it's workflow is not described

[IonicaBizau]

@glensc It's fine. I guess it should default to these computed values. If there are npm* fields already, use them. 👷