Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing minifed files for CodeMirror library #13226

Closed
Chi-teck opened this issue Jan 23, 2019 · 6 comments
Closed

Add missing minifed files for CodeMirror library #13226

Chi-teck opened this issue Jan 23, 2019 · 6 comments

Comments

@Chi-teck
Copy link

Chi-teck commented Jan 23, 2019

For instance, there is no fullscreen.min.css in the following directory.
https://github.com/cdnjs/cdnjs/tree/master/ajax/libs/codemirror/5.43.0/addon/display/


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@MattIPv4
Copy link
Member

MattIPv4 commented Jan 23, 2019

@Chi-teck Hi there, we pull codemirror from npm and looking at both the GitHub repository for codemirror as well as the npm tarball, fullscreen.min.css is not a file that they have and so we also do not have it: https://github.com/codemirror/CodeMirror/tree/master/addon/display

If you wish for codemirror to publish this file, please take it up with them :)

@Chi-teck
Copy link
Author

@MattIPv4 Can you explain how it works right now? CodeMirror itself does not provide minified files at all but cdnjs offers them for most files (fullscreen.min.css is just an exception).

@MattIPv4
Copy link
Member

@PeterDaveHello Where exactly are the minfied files coming from? npm doesn't have them, nor does the lib?

@PeterDaveHello
Copy link
Contributor

@MattIPv4 we minify files when there is no minified file of it, though we prefer to have it from upstream, to have better integrity and better specific optimization.

@Chi-teck
Copy link
Author

@PeterDaveHello why is fullscreen.css not minified? Also some other files. Based on my observation, there is some criteria for this based on file size.

@xtuc
Copy link
Member

xtuc commented Feb 20, 2020

As @PeterDaveHello said, that should probably be upstream

@xtuc xtuc closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants