Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for filename and git auto-update #4463

Closed
Ryuno-Ki opened this issue Mar 19, 2015 · 7 comments
Closed

Update README for filename and git auto-update #4463

Ryuno-Ki opened this issue Mar 19, 2015 · 7 comments

Comments

@Ryuno-Ki
Copy link

I'm currently process of getting a new lib into CDNjs (see #4456). Hereby I noticed, that filename in package.json isn't documented on the official npm docs, but required by the CI.

@PeterDaveHello pointed me to #3638 as well, so I'd suggest, you update the README in order to save some time on both ends. I assume, with git auto-update a update hook on server is meant …

@IonicaBizau
Copy link
Contributor

👍

I managed to find out the filename thing when I looked in the test files (tests were failing).

@PeterDaveHello
Copy link
Contributor

I think README told about this:

https://github.com/cdnjs/cdnjs#create-or-update-packagejson

(see test/schemata/npm-package.json for details or use another package.json to crib from - it's pretty self-explanatory)

Any way, I did something in 42eaf16, I think this may help, what do you think guys?

@Ryuno-Ki
Copy link
Author

@PeterDaveHello I miss the structure, the scripts expect to be there.
Strings, Arrays and so on. Wherefore is it used?
(By comparing and digging into the CI script I could figure it out …)

@PeterDaveHello
Copy link
Contributor

Sorry that I didn't get your point, what does Wherefore is it used? mean here?

@Ryuno-Ki
Copy link
Author

At which point, the values are consumed to accomplish which task?

@IonicaBizau
Copy link
Contributor

@Ryuno-Ki Look in the auto-update.js script.

@PeterDaveHello
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants