You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe we can just store the indices instead of converting to and from SmartStrings? We only need a Borrowed anyway at self.get() time. No idea if it would actually be faster.
The text was updated successfully, but these errors were encountered:
Oh, we do actually need key later as part of error reporting. Hmm.
I wonder if this in general would be better encapsulated with a single Formatter struct that holds format pieces (at first an empty Vec, populated on first run), formatters, and the format string. Then we could safely hold on to the &str because we still have the backing format string in this struct.
About ~12% of time is spent in doing conversions from &str to SmartString, which may require a reallocation anyway.
Maybe we can just store the indices instead of converting to and from SmartStrings? We only need a Borrowed anyway at self.get() time. No idea if it would actually be faster.
The text was updated successfully, but these errors were encountered: