Skip to content

Commit

Permalink
chore(ci): remove images and update publish flow (#3147)
Browse files Browse the repository at this point in the history
* chore(ci): remove unmaintained images
* chore(ci): update publish workflow
  • Loading branch information
Akash Satheesan committed Apr 16, 2021
1 parent 006438d commit cbc2e8b
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 101 deletions.
18 changes: 10 additions & 8 deletions .github/workflows/publish.yaml
Expand Up @@ -9,26 +9,28 @@ on:
types: [published]

jobs:
# NOTE: this job requires curl, jq and yarn
# All of them are included in ubuntu-latest.
npm:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2

- name: Run ./ci/steps/publish-npm.sh
uses: ./ci/images/debian10
with:
args: ./ci/steps/publish-npm.sh
run: ./ci/steps/publish-npm.sh
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

# NOTE: this job requires curl, jq and docker
# All of them are included in ubuntu-latest.
docker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v2

- name: Run ./ci/steps/push-docker-manifest.sh
uses: ./ci/images/debian10
with:
args: ./ci/steps/push-docker-manifest.sh
run: ./ci/steps/push-docker-manifest.sh
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
Expand Down
31 changes: 0 additions & 31 deletions ci/dev/image/run.sh

This file was deleted.

30 changes: 0 additions & 30 deletions ci/images/centos7/Dockerfile

This file was deleted.

40 changes: 8 additions & 32 deletions docs/CONTRIBUTING.md
Expand Up @@ -57,13 +57,6 @@ yarn watch
# Visit http://localhost:8080 once the build is completed.
```

To develop inside an isolated Docker container:

```shell
./ci/dev/image/run.sh yarn
./ci/dev/image/run.sh yarn watch
```

`yarn watch` will live reload changes to the source.

### Updating VS Code
Expand All @@ -89,7 +82,9 @@ To update VS Code, follow these steps:
You can build using:

```shell
./ci/dev/image/run.sh ./ci/steps/release.sh
yarn build
yarn build:vscode
yarn release
```

Run your build with:
Expand All @@ -101,37 +96,18 @@ yarn --production
node .
```

Build the release packages (make sure that you run `./ci/steps/release.sh` first):

```shell
IMAGE=centos7 ./ci/dev/image/run.sh ./ci/steps/release-packages.sh
# The standalone release is in ./release-standalone
# .deb, .rpm and the standalone archive are in ./release-packages
```

The `release.sh` script is equal to running:

```shell
yarn
yarn build
yarn build:vscode
yarn release
```

And `release-packages.sh` is equal to:
Build the release packages (make sure that you run `yarn release` first):

```shell
yarn release:standalone
yarn test:standalone-release
yarn package
```

For a faster release build, you can run instead:

```shell
KEEP_MODULES=1 ./ci/steps/release.sh
node ./release
```
NOTE: On Linux, the currently running distro will become the minimum supported version.
In our GitHub Actions CI, we use CentOS 7 for maximum compatibility.
If you need your builds to support older distros, run the build commands
inside a Docker container with all the build requirements installed.

## Structure

Expand Down

0 comments on commit cbc2e8b

Please sign in to comment.