Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS copy and cut keyboard shortcuts are not working #1015

Closed
schradeyannik opened this issue Sep 20, 2019 · 98 comments · Fixed by #2081
Closed

iOS copy and cut keyboard shortcuts are not working #1015

schradeyannik opened this issue Sep 20, 2019 · 98 comments · Fixed by #2081
Labels
bug Something isn't working
Milestone

Comments

@schradeyannik
Copy link

  • code-server 1.1156-vsc1.33.1
  • OS Version: iPadOS 13.1 Beta 4 (on iPad Pro 2018 12.9)

Description

The keyboard shortcuts for copying and cutting text don‘t work. Changing the shortcuts in the code-server settings to something different of „cmd+c“ and „cmd+x“ does not help.

Steps to Reproduce

  1. Open and edit a file.
  2. Try using „cmd+c“ or „cmd+x“.
  3. Change the shortcuts in the settings.
  4. Fail again.
@schradeyannik schradeyannik added the bug Something isn't working label Sep 20, 2019
@phoenixsfly
Copy link

please use desktop mode in safari.
trun on : Setting—Safari—Request dessktop website

@sr229
Copy link
Contributor

sr229 commented Sep 22, 2019

@schradeyannik AFAIK we do not support Safari in mobile mode, try using the Desktop mode. We have no plans to support mobile UAs due to Monaco's limitation.

@schradeyannik
Copy link
Author

@sr229 @phoenixsfly The desktop mode is activated. The mentioned keyboard shortcuts do not work in desktop mode.

@mattapperson
Copy link

Try using Control + C and Control + V

@schradeyannik
Copy link
Author

@mattapperson This does not work either.

@nhooyr
Copy link
Contributor

nhooyr commented Jan 28, 2020

Will test and get back to you.

@nhooyr nhooyr added needs-investigation and removed bug Something isn't working labels Jan 28, 2020
@dasalazar1
Copy link

dasalazar1 commented Mar 21, 2020

Any update on this bug? I’m having the same issue. iOS 13.3 iPad Air version 3.

Edit: So this is only in V3. Using the last build of V2 I’m having no issues with cut/copy/paste

@kylecarbs
Copy link
Member

@dasalazar1 not much of an update. Seems like more and more people wanna try this workflow, so we might prioritize it.

@code-asher we use the clipboard API right? So maybe we just have to adjust the keybind if they're on an iPad.

@code-asher
Copy link
Member

code-asher commented Mar 23, 2020 via email

@kylecarbs
Copy link
Member

Ah. I assume we could patch that quite easily.

@perelin
Copy link

perelin commented Mar 26, 2020

Same behaviour here. iPad Air 3, iOS 13.4

I just tried out the last V2 and it works there.

Using a V2 is the only workaround currently? (no copy/paste makes development work defacto impossible :)

@Brent-Hickey
Copy link

Seeing the same behavior. If it is a quick patch would love to see this fixed!

@pr1metine
Copy link

Same for me even when using Chrome.

@infinitedaremo
Copy link

Would love a fix for this.

@Brent-Hickey
Copy link

FYI a simple workaround I’ve used is to highlight the text, cmd+f, and then you can immediately cmd+c out of the search bar. Paste works as expected. This doesn’t solve cut, but it’s pretty usable

@gavinbd
Copy link

gavinbd commented Apr 8, 2020

That’s a brilliant temporary “fix”. Thank you.

Cmd + Shift + F allows you to copy entire blocks too.

@kylecarbs
Copy link
Member

I'm pretty sure this is because WebKit doesn't let us override copy/paste on mobile unfortunately.

@gavinbd
Copy link

gavinbd commented Apr 14, 2020

I'm pretty sure this is because WebKit doesn't let us override copy/paste on mobile unfortunately.

On iOS the copy button is just greyed out. It’s like text selection doesn’t recognise that text has been highlighted in the editor view. Paste does work already if you’ve got something in the clipboard.

@nhooyr nhooyr assigned cmoog and unassigned code-asher Apr 16, 2020
@nhooyr nhooyr added the iPad label Apr 17, 2020
@Mrc527
Copy link

Mrc527 commented Apr 27, 2020

Even from the context menu (Right button click) it does not work.

@Mrc527
Copy link

Mrc527 commented Apr 27, 2020

I'm pretty sure this is because WebKit doesn't let us override copy/paste on mobile unfortunately.

I’m not sure about this, considering that there is a working workaround and some reports V2 was working... Let’s keep finger crossed!

@demyxco
Copy link

demyxco commented Apr 27, 2020

Glad to see this is an open issue, why was the clipboard API removed in v3 for editors? V2 works flawlessly on my iPad Pro.

@christianjuth
Copy link

christianjuth commented Aug 31, 2020

Installed v3.5.0. I can't even get copy working by right clicking and selecting copy from the context menu. ☹️

Is also seems that chaning your user agent no longer fixes the issue.

@nhooyr nhooyr reopened this Aug 31, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

This sucks, was hoping upstream fixed it but I guess not :(

@wei
Copy link

wei commented Aug 31, 2020

@nhooyr according to microsoft/vscode#101702 it's in August 2020 milestone which will be in a early Sept release.

@AlfaJackal
Copy link

@nhooyr according to microsoft/vscode#101702 it's in August 2020 milestone which will be in a early Sept release.

Is it?

@nhooyr
Copy link
Contributor

nhooyr commented Aug 31, 2020

@wei I checked and v1.48.2 included the commits that were supposed to fix it.

@wei
Copy link

wei commented Aug 31, 2020

@daybrush
Copy link

daybrush commented Sep 2, 2020

@nhooyr

As @wei said, it doesn't seem to be fixed in 1.48.2.
We should hope the master's commit is released.

@wei
Copy link

wei commented Sep 2, 2020

Good news August 2020 milestone is in endgame. They are targeting next Wednesday/Thursday for release. Let's hope code-server team can bump up vscode version quicker this time 😉

@keiqsa
Copy link

keiqsa commented Sep 7, 2020

looks like copy paste work well in the app https://apps.apple.com/us/app/servediter-for-code-server/id1504491325

@christianjuth
Copy link

@keiqsa are you using a self hosted instance of code-server with the Servediter app or their hosted service? I tried to get the app to connect to my self hosted server, but it didn't work. Their app seems really buggy in general.

@dasalazar1
Copy link

@christianjuth It's a little buggy if you mess up the self hosted options. I got caught in a some kinda auth loop a few times and had to uninstall/reinstall to clear the settings. But once it's connected I've run self hosted for a while with no issues. Ended up turning auth off since I only have it exposed in my home network anyway.

@demyxco
Copy link

demyxco commented Sep 7, 2020

I use that app heavily due to it having a working copy/paste. My only gripe about it is that the app refreshes when switching to other apps, losing my open terminals and what not.

@dasalazar1
Copy link

@demyxco As far as I know that's an iOS limitation. Something about how long apps can retain state or activity in the background. I've had that complaint from other apps that do terminals. Textastic seems to be able to keep them open a bit longer but still not great.

@demyxco
Copy link

demyxco commented Sep 7, 2020

@dasalazar1 right, those other apps uses the location feature to prevent the app from refreshing. Maybe implement the same? The other thing also is scrolling loses it’s scroll momentum but I think that’s an upstream issue.

@dasalazar1
Copy link

@demyxco hmm okay. I didn't know that was the work around. There's issue #1455 for scrolling with trackpad. Not sure about the momentum.

@0x4007
Copy link

0x4007 commented Sep 10, 2020

Good news August 2020 milestone is in endgame. They are targeting next Wednesday/Thursday for release. Let's hope code-server team can bump up vscode version quicker this time 😉

My hopes are so high for today, Thursday.

@magicds
Copy link

magicds commented Sep 30, 2020

code-server: v3.5.0
VS Code: v1.48.2
Commit: de41646
Date: 2020-08-31T09:43:23Z
Browser: Mozilla/5.0 (iPad; CPU OS 14_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/85.0.4183.109 Mobile/15E148 Safari/604.1

Have same problem

@code-asher code-asher linked a pull request Sep 30, 2020 that will close this issue
@code-asher
Copy link
Member

Merged the latest VS Code, will be in 3.6.0 very soon. Keep an eye on the milestone to see progress.

@kennymatic
Copy link

Merged the latest VS Code, will be in 3.6.0 very soon. Keep an eye on the milestone to see progress.

It works!

@enesccinar
Copy link

@keiqsa are you using a self hosted instance of code-server with the Servediter app or their hosted service? I tried to get the app to connect to my self hosted server, but it didn't work. Their app seems really buggy in general.

It's been a while but I wanted you to know that I am using self-hosted server and it works well for me. I've just tried it /w code-server 3.3.1.

@ManiaciaChao
Copy link

The issue still exists in v4.0.1.

I can't use cmd+[X/C/V] to cut/copy/paste the entire line from PWA on iPad. The only solution here is still Servereditor app.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 18, 2022

@ManiaciaChao can you provide a video? I could have sworn this was fixed now

@ManiaciaChao
Copy link

@ManiaciaChao can you provide a video? I could have sworn this was fixed now

Thanks for your reply :) I've sent the video directly into your Gmail. Plz check.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 19, 2022

@ManiaciaChao can you post it here instead please? That way, everyone can see it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.