Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(testing): separate unit and e2e tests #2852

Merged
merged 10 commits into from Mar 15, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 9, 2021

This PR fixes #2646 by separating unit and e2e testing. Hopefully this speeds things up with CI.

@jsjoeio jsjoeio requested a review from a team as a code owner March 9, 2021 23:42
@jsjoeio jsjoeio changed the title jsjoeio-2646-separate-testing dev(testing): separate unit and e2e tests Mar 9, 2021
@jsjoeio jsjoeio added this to 🚧 In progress in Improve Testing via automation Mar 9, 2021
@jsjoeio jsjoeio added this to 🚧 In progress in Clean Up via automation Mar 9, 2021
@jsjoeio jsjoeio added this to the v3.9.2 milestone Mar 9, 2021
@jsjoeio jsjoeio marked this pull request as draft March 9, 2021 23:59
@jsjoeio jsjoeio self-assigned this Mar 10, 2021
.eslintrc.yaml Outdated
Comment on lines 35 to 41
[
error,
{
alphabetize: { order: "asc" },
groups: [["builtin", "external", "internal"], "parent", "sibling"],
},
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄

.eslintrc.yaml Outdated Show resolved Hide resolved
test/unit/test-plugin/src/index.ts Outdated Show resolved Hide resolved
@jsjoeio jsjoeio force-pushed the jsjoeio-2646-separate-testing branch from e09359a to 5a5c78a Compare March 10, 2021 19:30
@jsjoeio jsjoeio marked this pull request as ready for review March 10, 2021 21:24
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the off -> 0 thing, LGTM otherwise!

.eslintrc.yaml Outdated Show resolved Hide resolved
@jsjoeio jsjoeio force-pushed the jsjoeio-2646-separate-testing branch from 5a5c78a to 7e23575 Compare March 12, 2021 19:01
@jsjoeio jsjoeio requested a review from oxy March 12, 2021 19:01
Copy link

@oxy oxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsjoeio jsjoeio merged commit ca56440 into main Mar 15, 2021
Improve Testing automation moved this from 🚧 In progress to ✅ Done Mar 15, 2021
@jsjoeio jsjoeio deleted the jsjoeio-2646-separate-testing branch March 15, 2021 17:40
Clean Up automation moved this from 🚧 In progress to ✅ Done Mar 15, 2021
@jsjoeio jsjoeio mentioned this pull request Mar 15, 2021
@jsjoeio jsjoeio added the testing Anything related to testing label May 14, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev]: separate unit and end-to-end testing
2 participants