Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib/vscode): cleanup/update build deps #3314

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

oxy
Copy link

@oxy oxy commented May 7, 2021

Clean up some dependencies with security issues that we never touch in our build process, and also update vsce. Tested locally, fingers crossed it all works 🤞

@oxy oxy requested a review from a team as a code owner May 7, 2021 19:32
@oxy oxy self-assigned this May 7, 2021
@oxy oxy added this to the v3.10.0 milestone May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #3314 (c7bed92) into main (65c2510) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3314   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c2510...c7bed92. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working locally for me as well! LGTM!

Screen.Recording.2021-05-07.at.12.57.14.PM.mov

@oxy oxy merged commit 02a0e05 into main May 7, 2021
@oxy oxy deleted the oxy/remove-electron-osx-sign branch May 7, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants