fix: ensure (Logger).exit is non-nil before calling #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On an empty logger (which we use), it's possible for (Logger).Fatal to panic when attempting to call exit. This ensures that `l.exit` isn't nil before calling it.
jawnsy
reviewed
Dec 9, 2021
jawnsy
approved these changes
Dec 9, 2021
coadler
force-pushed
the
colin/empty-logger-panic
branch
from
ef7062e
to
92a299a
Compare
jawnsy
reviewed
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an empty logger (which we use), it's possible for (Logger).Fatal to
panic when attempting to call exit. This ensures that
l.exitisn't nilbefore calling it.