Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove direct coupling of opencensus #73

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Remove direct coupling of opencensus #73

merged 1 commit into from
Dec 12, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Dec 12, 2019

Closes #69

Thanks @peterbourgon

@nhooyr nhooyr requested a review from ammario December 12, 2019 01:08
@nhooyr nhooyr merged commit a44f627 into master Dec 12, 2019
@nhooyr nhooyr deleted the opencensus branch December 12, 2019 01:12
nhooyr added a commit that referenced this pull request Dec 12, 2019
@nhooyr
Revert "Merge pull request #73 from cdr/opencensus"
97798d6 
This reverts commit a44f627, reversing
changes made to 8f021e1.
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 12, 2019

Decided to revert this since we're still going to depend on opencensus everywhere and tracing is something that should be explicitly part of SinkEntry imo since every logger should try and support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario Awaiting requested review from ammario

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove opencensus integration from the core library
1 participant
@nhooyr