Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] #99

Closed
cdrani opened this issue Sep 3, 2023 · 1 comment · Fixed by #101
Closed

[BUG] #99

cdrani opened this issue Sep 3, 2023 · 1 comment · Fixed by #101
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cdrani
Copy link
Owner

cdrani commented Sep 3, 2023

Describe the bug

The manifest.json file has now been moved out of the root project folder and separated into chrome/manifest.json and firefox/manifest.json files. This change is now resulting in the below issue with shields.io badge:

image

Expected behavior

The version badge should display the current version of the latest release. Currently it's 1.6.1? Anyways, the shields badge url should be changed to reference the manifest.json in the firefox directory. It should be as simple as including the filename query param to the shields route. You can test it on the shields.io site before applying it to the README.

Additional context

While referencing the link above, I would welcome updates to the colour of the other labels. A majority of them are some variant of green, but I would love to see some bright blues, pinks, purples, etc. Maybe update the style as well, but they all badges in the README would need to be update to the new style for uniformity.

Here's the particular line to focus on:

<img alt="GitHub manifest version" src="https://img.shields.io/github/manifest-json/v/cdrani/chorus">

@cdrani cdrani added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers labels Sep 3, 2023
@kasai2210
Copy link
Contributor

kasai2210 commented Sep 3, 2023

Hi, I just raised a PR against this bug, kindly review and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

2 participants