feat: Add/create @cdssnc/gcds-components-vue package #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daine
reviewed
May 6, 2024
daine
requested changes
May 14, 2024
There was a problem hiding this comment.
Just adds one more update to the README -- I'm aware there might be translation changes as well.
Also, I tested this using this example app and it works pretty well (granted I only really tested the select and header components but it was fun seeing it!)
Co-authored-by: Daine Trinidad <daine.trinidad@cds-snc.ca>
…/gcds-components into feat/gcds-components-vue
|
Hopefully that last commit was the last one |
daine
previously approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
For easier integration with Vue 3, add the
@cdssnc/gcds-components-vuepackage. This provides the GC Design System components within Vue component wrappers.