feat: Conditional Input History - Forms-form #4036
Open
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiessenp-cds
changed the title
🧪 Review environmenthttps://4ouzqz4a6gfkj4pxecb6jjky5i0zfqfc.lambda-url.ca-central-1.on.aws/ |
timarney
reviewed
Jul 19, 2024
timarney
reviewed
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditional Input History - Forms-form
Adds conditional input history to the forms-forms.
This adda the logic from group history and show-hide to only include the data that follows a user's branching path.
High Risk PR as this touches forms-forms (how a user submits data)
Testing
The main things to test are that nothing obvious is broken around form submissions. Also test that the correct data is submitted. See the below video for an example.
Also test that old forms work as they previously did. So a review page should not be displayed when submitting and submissions continue working as previously.
Screen.Recording.2024-07-19.at.8.52.36.AM.mov