You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is possible for the Preview page to load invalid JSON and if this happens there is currently no good way to notify the user this happened.
For this error to occur, a user would need to directly access /form-builder/0000/preview and the parsed JSON from getSchema() contain invalid JSON. I've only been able to simulate this manually in the code. But it is still a possible error and potentially an error that would seriously confuse a user.
For example, a user would see this toast about invalid JSON. Then If s/he clicked download, the default template would be downloaded which is valid JSON. (and hide the file with invalid JSON)
An initial PR was done to handle thrown errors from JSON here: #3995
This is a followup PR to think about how best to handle this error case.
The text was updated successfully, but these errors were encountered:
It is possible for the Preview page to load invalid JSON and if this happens there is currently no good way to notify the user this happened.
For this error to occur, a user would need to directly access
/form-builder/0000/preview
and the parsed JSON fromgetSchema()
contain invalid JSON. I've only been able to simulate this manually in the code. But it is still a possible error and potentially an error that would seriously confuse a user.For example, a user would see this toast about invalid JSON. Then If s/he clicked download, the default template would be downloaded which is valid JSON. (and hide the file with invalid JSON)
![Screenshot 2024-07-19 at 2 06 39 PM](https://private-user-images.githubusercontent.com/107579368/350513085-72675558-3f32-42cc-a49f-0a73e725075f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE3NTYyNjEsIm5iZiI6MTcyMTc1NTk2MSwicGF0aCI6Ii8xMDc1NzkzNjgvMzUwNTEzMDg1LTcyNjc1NTU4LTNmMzItNDJjYy1hNDlmLTBhNzNlNzI1MDc1Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyM1QxNzMyNDFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ODhlNDZkY2ZjZmM0MzllMzk5ZWY4NjE5ODU5OTNjNWVlNjAyZmViOTc1MmUyY2Y3ODBmOTE4YjcxMTMwZTI3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.zuAxmNK7QvhlcO6GY2ez8jEJrwYOTKoC8qdnSbivsBY)
An initial PR was done to handle thrown errors from JSON here: #3995
This is a followup PR to think about how best to handle this error case.
The text was updated successfully, but these errors were encountered: