InfluxDbProvider not write tags in build measurement

[Alex009]

hello!

Default graphana dashboard can't show graph with executed task because build measurement not contains any tags at all.

SELECT mean("duration") FROM "tracking"."rpTalaiot"."build" WHERE $timeFilter GROUP BY "requestedTasks", time($__interval) fill(null)

it's used query for graph.
in result we got one group without name:

also chronograf show that build measurement not contains tags at all:

but task will:

also code really not contains tags publish...why?
https://github.com/cdsap/Talaiot/blob/1.3.5/talaiot/src/main/kotlin/com/cdsap/talaiot/publisher/InfluxDbPublisher.kt#L131

[cdsap]

Hi @Alex009 thanks for sending the issue.
I checked the code and you are completely right. This change was introduced in release 1.3(621d26a).

I'm still thinking that metrics and custom metrics should be provided as fields, for example high cardinality values like java memory metrics can affect the performance being tags. But we could revert to the previous version having tags and fields. To have more context, in your specific case what's metrics/env values should be defined as tags?

[Alex009]

@cdsap in my case all my custom metrics should be tags, also all not numbers default metrics should be tags too, for example gitUser, gitBranch...
i think it will be correct if in publisher will be automatic resolving tags and fields by type of metric value - all number types should be fields, but others is tags.
or just give consumer ability to set list of tags metric names

[cdsap]

@Alex009 it's very good idea, I think we will work soon on this feature for the influxfb plugin.

[alaershov]

Updated to 0.8.0 to support AGP 4.1.2 and Gradle 6.8.2, and this issue affects me greatly as well.
Maybe we could configure which metrics should be only fields? It would add a controllable performance overhead as not all fields would become tags, but only a selected few.

[tinder-inakivillar]

Hi @alaershov, working on this issue , hope to have something on the weekend

[alaershov]

I see you've fixed this issue, that's awesome! Can we please have a release with tag support?

[cdsap]

hi @alaershov you have the release 1.4.2 available including the tags setup.
I'm waiting one more day to make the announcement and finish the release notes.
if you want to test now it works like:

publishers {
        influxDbPublisher {
            dbName = "tracking"
            url = "http://localhost:8086"
            taskMetricName = "task"
            buildMetricName = "build"
            tags = [com.cdsap.talaiot.metrics.BuildMetrics.RemoteCacheHit]
        }
    }

It supports current metrics https://github.com/cdsap/Talaiot/blob/master/library/core/talaiot/src/main/kotlin/com/cdsap/talaiot/metrics/BuildMetrics.kt and custom metrics

[cdsap]

version has been officially released, https://github.com/cdsap/Talaiot/releases/tag/1.4.2.
Let me know If I can close the issue @alaershov

[alaershov]

Thanks a lot, works perfectly for us!

[jan-stoltman-bolt]

Hey @cdsap I think that this issue can be safely closed