New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favicon is hard to see on dark backgrounds #297
Comments
I think the favicon and icon both have too dark a color -- i.e. it has never been the "brand" color (which has no changed to be lighter as well). Can you add some screenshots of where you see it as bad now? |
Sure. For the favicon, see if you can spot it here (using this Chrome theme): For the icon, frankly, right there in the header, the dark-blue-on-dark-grey seems low-contrast to me. Text is a slightly brighter blue, too. |
Header I was talking about: Note how the word "baby" is brighter than the icon. For the contrast between the icon and the background, we get a constrast ratio of 1.4 (same page explains that the recommendation is at least 3). |
Those blues are different because you changed the blues 😛 If the icon used the new blue would it be passable? Or do we really need to do more here? Also, FTR, I think the icon blue has never been right, hah. I need to dig up the original icon files... |
🤣 my memory is exactly as good as I remembered Using the new blue would fix #297 (comment) but not #297 (comment). I think it should be done for consistency regardless, but while we're at it - add a white outline. |
That's, uh, terrifying 😅 on a blue background, you'd see just the eyes, too. I'd drop the white eyes in favor of an outline around the whole shape. |
[squints] Does it? The best test is "how would it fare on a background that happens to be the same color as the foreground", and my guess is that it would disappear. |
Here's what I had in mind - I made this in gimp starting with Option 1: Option 2: |
Haha yeah the current brand icon on I'll give a thicker stroke a try again later. To me it seemed like it would look bad on dark backgrounds... |
Looks pretty good to me on Github Dark Mode. |
Yeah, still looks good to me... I gather you don't like it. I'm not much of an artist 😅 |
Haha me neither. The second one with filled in details look like it may work so I'll run a variant of that through a full test. There is also some way to handle different versions for dark/light mode but I'm unclear on that standard/how it integrates with browser usage of the favicon. |
Alright I fiddled with this a lot and didn't come up with a "works in all scenarios" version that I liked. I'm sticking with the updated theme blue and changing to an SVG icon (that does have a dark mode setting that browser may or may not use 🤷). |
Switched my browser to a night-mode dark blue theme and... where did babybuddy go? Oh yeah, it's dark-blue-on-slightly-darker-blue. I don't have the know-how to do this neatly, especially with the smaller pixel sizes, but I'd advise:
The text was updated successfully, but these errors were encountered: