Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon is hard to see on dark backgrounds #297

Closed
lutzky opened this issue Aug 31, 2021 · 17 comments · Fixed by #312
Closed

Favicon is hard to see on dark backgrounds #297

lutzky opened this issue Aug 31, 2021 · 17 comments · Fixed by #312
Labels
enhancement Feature requests or improvements to existing functionality ui/ux Issues relating to user interface/experience

Comments

@lutzky
Copy link
Contributor

lutzky commented Aug 31, 2021

Switched my browser to a night-mode dark blue theme and... where did babybuddy go? Oh yeah, it's dark-blue-on-slightly-darker-blue. I don't have the know-how to do this neatly, especially with the smaller pixel sizes, but I'd advise:

  • Easy, but would look very different: Make eyes, mouth and clock-hands white
  • Hard, but would retain general aesthetic: Add a thin white border around the entire silhouette
@cdubz
Copy link
Member

cdubz commented Aug 31, 2021

I think the favicon and icon both have too dark a color -- i.e. it has never been the "brand" color (which has no changed to be lighter as well). Can you add some screenshots of where you see it as bad now?

@cdubz cdubz added enhancement Feature requests or improvements to existing functionality ui/ux Issues relating to user interface/experience labels Aug 31, 2021
@lutzky
Copy link
Contributor Author

lutzky commented Aug 31, 2021

Sure. For the favicon, see if you can spot it here (using this Chrome theme):

Invisible

For the icon, frankly, right there in the header, the dark-blue-on-dark-grey seems low-contrast to me. Text is a slightly brighter blue, too.

@lutzky
Copy link
Contributor Author

lutzky commented Aug 31, 2021

Header I was talking about:

Header

Note how the word "baby" is brighter than the icon. For the contrast between the icon and the background, we get a constrast ratio of 1.4 (same page explains that the recommendation is at least 3).

@cdubz
Copy link
Member

cdubz commented Aug 31, 2021

Those blues are different because you changed the blues 😛

If the icon used the new blue would it be passable? Or do we really need to do more here? Also, FTR, I think the icon blue has never been right, hah.

I need to dig up the original icon files...

@lutzky
Copy link
Contributor Author

lutzky commented Aug 31, 2021

🤣 my memory is exactly as good as I remembered

Using the new blue would fix #297 (comment) but not #297 (comment). I think it should be done for consistency regardless, but while we're at it - add a white outline.

@cdubz
Copy link
Member

cdubz commented Sep 18, 2021

Ok finally started working on this. There is a certain ghostly theme to the current iteration lol 👻

image

I may need to find/enlist some help from someone who actually knows how to work with SVG files...

@lutzky
Copy link
Contributor Author

lutzky commented Sep 18, 2021

That's, uh, terrifying 😅 on a blue background, you'd see just the eyes, too. I'd drop the white eyes in favor of an outline around the whole shape.

@cdubz
Copy link
Member

cdubz commented Sep 20, 2021

Thoughts on this? It has a very light white border --

image

@lutzky
Copy link
Contributor Author

lutzky commented Sep 20, 2021

[squints]

Does it? The best test is "how would it fare on a background that happens to be the same color as the foreground", and my guess is that it would disappear.

@cdubz
Copy link
Member

cdubz commented Sep 20, 2021

It does! Anything thicker really mashes up the details. The only other option that works, I think, would be to use a background with the image but I think that is the less attractive option --

image

@lutzky
Copy link
Contributor Author

lutzky commented Sep 20, 2021

Here's what I had in mind - I made this in gimp starting with icon-brand.png - which, incidentally, is partially transparent! Is that on purpose? I fought it by duplicating the layer 4 times. (Border was added by adding another layer below, "alpha to selection" + grow selection by 2px.

Option 1:

icon-border

Option 2:

icon-border2

@cdubz
Copy link
Member

cdubz commented Sep 20, 2021

Haha yeah the current brand icon on master is a mess. I'm also updating these assets generally in #312 so there are better starting points there (including SVGs).

I'll give a thicker stroke a try again later. To me it seemed like it would look bad on dark backgrounds...

@lutzky
Copy link
Contributor Author

lutzky commented Sep 20, 2021

Looks pretty good to me on Github Dark Mode.

@cdubz
Copy link
Member

cdubz commented Sep 20, 2021

Yeah but at favicon size?

image

image

@lutzky
Copy link
Contributor Author

lutzky commented Sep 20, 2021

Yeah, still looks good to me... I gather you don't like it. I'm not much of an artist 😅

@cdubz
Copy link
Member

cdubz commented Sep 20, 2021

Haha me neither. The second one with filled in details look like it may work so I'll run a variant of that through a full test. There is also some way to handle different versions for dark/light mode but I'm unclear on that standard/how it integrates with browser usage of the favicon.

@cdubz
Copy link
Member

cdubz commented Sep 25, 2021

Alright I fiddled with this a lot and didn't come up with a "works in all scenarios" version that I liked. I'm sticking with the updated theme blue and changing to an SVG icon (that does have a dark mode setting that browser may or may not use 🤷).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality ui/ux Issues relating to user interface/experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants