Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render issues for header and separator #27

Closed
iJackUA opened this issue Feb 18, 2014 · 6 comments
Closed

Render issues for header and separator #27

iJackUA opened this issue Feb 18, 2014 · 6 comments

Comments

@iJackUA
Copy link

iJackUA commented Feb 18, 2014

Hi, I have found couple render issues when some tags are not displayed.
Not sure maybe it is wrong Markdown markup, but other parser (I test Ciconia, php-markdown, parsedown and your one) display it as expected

Example 1
selection_079

# hello, This is Markdown Live Preview

----
## what is Markdown?
see [Wikipedia](http://en.wikipedia.org/wiki/Markdown)

{mycustom_widget}

### Tasks list
- [x] @mentions, #refs, [links](), **formatting**, and <del>tags</del> supported
- [x] list syntax required (any unordered or ordered list supported)
- [x] this is a complete item
- [ ] this is an incomplete item
- [x] @mentions, #refs, [links](), **formatting**, and <del>tags</del> supported


* SHA: 16c999e8c71134401a78d4d46435517b2271d6ac
* User@SHA: mojombo@16c999e8c71134401a78d4d46435517b2271d6ac
* User/Repository@SHA: mojombo/github-flavored-markdown@16c999e8c71134401a78d4d46435517b2271d6ac
* #Num: #1
* User#Num: mojombo#1
* User/Repository#Num: mojombo/github-flavored-markdown#1

Example 2
selection_080

----

## changelog 1

* 17-Feb-2013 re-design

----
## changelog 2
* 17-Feb-2013 re-design
@cebe
Copy link
Owner

cebe commented Feb 18, 2014

Thanks for pointing this out! I am aware of this issue but was not sure how or whether to fix it at all. The original specs are not 100% clear about it and there are cases where you do not want this to work.
e.g.

Lorem ipsum dolor sit amet. The company xyz was founded in
1985. After that it grew....

You do not want to have a list started here.

Current implementation expects a blank line between different block elements. Will check how we can fix this.

@cebe cebe added this to the 1.0.0 milestone Feb 18, 2014
@samdark
Copy link
Contributor

samdark commented Feb 18, 2014

For the cases mentioned it's all about blank lines after headers. I don't think these are mandatory in this case.

@iJackUA
Copy link
Author

iJackUA commented Feb 18, 2014

@samdark not only header
in first case Header without line break "killed" first line under it
and in second case hr element killed header under it

it is really unexpected behavior
for example from GitHub's markdown manual

# The largest heading (an <h1> tag)
## The second largest heading (an <h2> tag)
…
###### The 6th largest heading (an <h6> tag)

total mess

selection_082

@samdark
Copy link
Contributor

samdark commented Feb 18, 2014

Well, yeah. HR is the same case where it doesn't make sense to require extra space.

@cebe
Copy link
Owner

cebe commented Feb 18, 2014

Working on a fix already.

@cebe cebe modified the milestones: 1.0.0, 0.9.2 Feb 18, 2014
@cebe cebe closed this as completed in 8d035ac Feb 18, 2014
@cebe
Copy link
Owner

cebe commented Feb 18, 2014

Should all be fixed by 8d035ac. If you encounter more cases like this (even if they pass), please add them to the test file or paste them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants