Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalizeUri does not normalizes windows file urls #22

Closed
scaytrase opened this issue May 8, 2019 · 2 comments · Fixed by #25
Closed

NormalizeUri does not normalizes windows file urls #22

scaytrase opened this issue May 8, 2019 · 2 comments · Fixed by #25
Labels
bug Something isn't working
Milestone

Comments

@scaytrase
Copy link
Contributor

I was running tests locally on windows for library and got an exception instead of green test

image

Looks like code ignores windows path notation while all other code work OK with it (since file still could be read)

@cebe cebe added the bug Something isn't working label May 9, 2019
@cebe
Copy link
Owner

cebe commented May 9, 2019

Thanks for reporting, I have no windows environment to test on, so I was not aware of this.

Seems travis has an option to run tests on windows, will try that.
https://docs.travis-ci.com/user/reference/windows/

@lezhnev74
Copy link
Contributor

This tutorial helped me to reproduce the bug in the VirtualBox:

https://www.jeffgeerling.com/blog/2018/installing-php-7-and-composer-on-windows-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants