TextField params pass through

[vasilich6107]

Is there any specific reason to pass through so few arguments to the textfield?
https://github.com/cedvdb/phone_form_field/blob/dev/lib/src/widgets/phone_field.dart#L150

The TextField has much more arguments that user would like to pass

[cedvdb]

There is no technical reason. The reason originally was to keep it simple and for convenience of development, added on a request basis. I can add all of those at once though so it's done.

Those will be added, others do not make sens on such an input (capitalization, maxLines,...)

    this.style,
    this.strutStyle,
    this.textAlign = TextAlign.start,
    this.textAlignVertical,
    this.textDirection,
    ToolbarOptions? toolbarOptions,
    this.showCursor,
    obscuringCharacter = '•',
     obscureText = false,
    autocorrect = true,
    SmartDashesType? smartDashesType,
    SmartQuotesType? smartQuotesType,
    this.enableSuggestions = true,    
    this.onSubmitted,
    this.onAppPrivateCommand,
    this.cursorWidth = 2.0,
    this.cursorHeight,
    this.cursorRadius,
    this.cursorColor,
    this.selectionHeightStyle = ui.BoxHeightStyle.tight,
    this.selectionWidthStyle = ui.BoxWidthStyle.tight,
    this.keyboardAppearance,
    this.scrollPadding = const EdgeInsets.all(20.0),
    this.dragStartBehavior = DragStartBehavior.start,
    this.enableInteractiveSelection = true,
    this.selectionControls,
    this.onTap,
    this.mouseCursor,
    this.buildCounter,
    this.scrollController,
    this.scrollPhysics,
    this.enableIMEPersonalizedLearning = true,
    ```

[cedvdb]

should be fixed for 4.3.0, not published yet, awaiting potential other requests from you

branch issue-69-params-passthrough

[vasilich6107]

Hi @cedvdb
What about focusNode and controller?

[cedvdb]

Those are both somewhat already there

The controller given to TextField is not the same as the controller given to the PhoneFormField. That's because the value of the controller is a PhoneNumber and not text (there is the country code as well as national phone number).

It would not make sens to give access to the underlying TextField controller.

As for the focusNode I added the possibility to override the one set by the lib.

Just to be clear:

    return TextField(
      focusNode: _focusNode,  // this can be overriden
      controller: _nationalNumberController, // this cannot

[vasilich6107]

Here is an example of possible issue if we will not expose controller
joanpablo/reactive_forms#210

[vasilich6107]

You can refer to this package history when you are thinking about properties exposure
https://pub.dev/packages/dropdown_search

10-20% of bugfixes was related to proper properties exposure)))
The next day your package become famous you'll be constantly getting those issues Please expose this, Please expose that)))

[cedvdb]

I'm making some modification so the text is selectable from the main controller.

In flutter selecting the text does not mean that the text will have focus (You can't necessarily edit it). Is the expected behavior to have focus on the field automatically after selection, or to manually have to call focusNode.requestFocus() ?

[cedvdb]

It is now published on 4.3.0.

You can now select from the main controller https://cedvdb.github.io/phone_form_field/#/

(there is a selection button at the bottom of the demo)