Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example number is considered invalid #18

Closed
EyMaddis opened this issue Nov 4, 2021 · 2 comments
Closed

example number is considered invalid #18

EyMaddis opened this issue Nov 4, 2021 · 2 comments

Comments

@EyMaddis
Copy link

EyMaddis commented Nov 4, 2021

Hi,
I noticed that a test number I have +44 7000000002 works in libphonenumber, but not with this library.

I am not sure why, because it seems that you use libphonenumbers metadata...

@cedvdb
Copy link
Owner

cedvdb commented Nov 7, 2021

It seems like a bug was introduced in the last update. Thanks, I'll fix that right now

@cedvdb cedvdb closed this as completed in 5ada966 Nov 7, 2021
@cedvdb
Copy link
Owner

cedvdb commented Nov 7, 2021

fixed in 4.2.0

cedvdb added a commit that referenced this issue Nov 7, 2021
* Only modify national number to its international version when it is valid (#14)

* only modify phone number when valid

* valid modif changelog

* slight modif on operator for future local

* new version number

* invalid backsubstitution (#15)

* Validate length fix #18 (#19)

* 4.1.0 back substitution when invalid (#16)

* Only modify national number to its international version when it is valid (#14)

* only modify phone number when valid

* valid modif changelog

* slight modif on operator for future local

* new version number

* invalid backsubstitution (#15)

* 4.1.0 (#17)

* Only modify national number to its international version when it is valid (#14)

* only modify phone number when valid

* valid modif changelog

* slight modif on operator for future local

* new version number

* invalid backsubstitution (#15)

* fix invalid validation

* remove print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants