SPM support #47
SPM support #47
Conversation
|
This would fix #11. |
mateuszmackowiak
force-pushed
the
spm
branch
from
4275ee5
to
c03cf80
Compare
There was a problem hiding this comment.
Hi @mateuszmackowiak. Firstly, thank you for taking the time to work on this pull request, and apologies that it has taken me so long to follow up.
I'd like to get this merged ASAP as it appears to be in high demand. One thing that stood out to me compared to the other SwiftPM PRs is all of the .swiftpm files. I tried to figure out whether these are necessary to checkin and it appears people usually add the .swiftpm directory to their .gitignore. I found the SPM folks doing it themselves here.
Unless you have a reason for checking this in, would you be able to add .swiftpm to the .gitignore and remove the files under the .swiftpm directory?
| @@ -4,8 +4,8 @@ | |||
|
|
|||
| # Solar | |||
|
|
|||
| [](http://cocoapods.org/pods/Solar) [](https://github.com/Carthage/Carthage) [](https://travis-ci.org/ceeK/Solar) | |||
| [](https://raw.githubusercontent.com/hyperium/hyper/master/LICENSE) | |||
| [](http://cocoapods.org/pods/Solar) [](https://github.com/Carthage/Carthage) [](https://cocoapods.org) [](https://swift.org/package-manager/) [](https://travis-ci.org/ceeK/Solar) | |||
Solar iOSTests/Solar_iOSTests.swift
Outdated
| }() | ||
|
|
||
| override func setUpWithError() throws { |
Done. I also made the minimum deployment targets more consistent among CocoaPods, Carthage, and SPM, though #29 tracks supporting more of the platforms with Carthage. |
Solar requires macOS 10.10, tvOS 9, or watchOS 3 when using SPM and macOS 10.9 or watchOS 3 when using Carthage for consistency with CocoaPods.
|
LGTM! |
|
And thank you @1ec5 for going through all this! 🙌 |
SPM support for the library.
I have changed the sample json file to use multilane string to be compatible with sim prior swift 5.3 (resources).
Both Carthage and pods version are still supported.
SPM package contains passing tests and I have defined other supported platforms
iOS(.v8), .macOS(.v10_15), .watchOS(.v4), .tvOS(.v11)Fixes #11.