New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fluids - Compressible Blasius boundary layer #1039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeilaGhaffari
commented
Aug 7, 2022
jedbrown
reviewed
Aug 7, 2022
LeilaGhaffari
force-pushed
the
leila/fluids-comp-blasius
branch
2 times, most recently
from
August 10, 2022 19:06
29eb8f5
to
04de162
Compare
LeilaGhaffari
force-pushed
the
leila/fluids-comp-blasius
branch
from
August 25, 2022 21:16
23910a7
to
38ed64f
Compare
I think I am going to add primitive variables to this problem after #1035 is merged. |
jedbrown
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. The only real thing is that I think the SNES solver can move to blasius.c
.
Thanks @jedbrown . I am happy with a |
Co-authored-by: Jed Brown <jed@jedbrown.org>
Co-authored-by: Jed Brown <jed@jedbrown.org>
LeilaGhaffari
force-pushed
the
leila/fluids-comp-blasius
branch
from
August 27, 2022 16:00
7faa49a
to
d5c852a
Compare
jrwrigh
approved these changes
Aug 27, 2022
jedbrown
reviewed
Aug 28, 2022
LeilaGhaffari
added a commit
that referenced
this pull request
Aug 30, 2022
jedbrown
added a commit
that referenced
this pull request
Sep 6, 2022
* main: (63 commits) Fix t568 bug (#1065) ci: patch occa-1.1.0 for spurious sys/sysctl.h t568-operator: fix input order and make test handle nan; skip on broken backends ci: use Noether for CUDA, handle CUDA on Debian CUDA_DIR=/usr examples/petsc: fix missing PetscFunctionBegin Fluids - Blasius: Some Minor Modifications (#1063) ci - newer xsmm for ci Icl/magma ntgemm (#1060) Fluids - fix blasius test Fluids - Some fixes missing from #1039 (#1056) Freed orient's array fluids: Add STATIC and print-% to makefile fluids: Set solution time label for strong stg Fluids - Compressible Blasius boundary layer (#1039) doc: Update fluids state_var option fluids: Switch to StateVar enum JIT: free relative path variable after getting absolute path magma: free memory used in loading jit kernel source fluids: Use newtonian with StateFromQi*_t func pointers fluids: Use StateFromQi* for newt boundary QFs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not converging yet and I am not sure where to use the exact temperature in the in/outflow BCs.