Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluids - Compressible Blasius boundary layer #1039

Merged
merged 7 commits into from Aug 28, 2022

Conversation

LeilaGhaffari
Copy link
Member

This is not converging yet and I am not sure where to use the exact temperature in the in/outflow BCs.

@LeilaGhaffari LeilaGhaffari force-pushed the leila/fluids-comp-blasius branch 2 times, most recently from 29eb8f5 to 04de162 Compare August 10, 2022 19:06
@LeilaGhaffari
Copy link
Member Author

I think I am going to add primitive variables to this problem after #1035 is merged.

Copy link
Member

@jedbrown jedbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. The only real thing is that I think the SNES solver can move to blasius.c.

examples/fluids/qfunctions/blasius_exact.h Outdated Show resolved Hide resolved
examples/fluids/qfunctions/blasius_exact.h Outdated Show resolved Hide resolved
examples/fluids/qfunctions/blasius_exact.h Outdated Show resolved Hide resolved
examples/fluids/qfunctions/blasius.h Outdated Show resolved Hide resolved
examples/fluids/problems/blasius.c Outdated Show resolved Hide resolved
@LeilaGhaffari
Copy link
Member Author

Thanks @jedbrown . I am happy with a squash-merge if this looks good to you now.

examples/fluids/qfunctions/blasius.h Show resolved Hide resolved
examples/fluids/qfunctions/blasius.h Show resolved Hide resolved
@LeilaGhaffari LeilaGhaffari merged commit 2518f33 into main Aug 28, 2022
@LeilaGhaffari LeilaGhaffari deleted the leila/fluids-comp-blasius branch August 28, 2022 14:06
LeilaGhaffari added a commit that referenced this pull request Aug 30, 2022
* Fluids - Blasius: drop theta0, style, and update README

* Fluids - Add regression test for laminar blasius
jedbrown added a commit that referenced this pull request Sep 6, 2022
* main: (63 commits)
  Fix t568 bug (#1065)
  ci: patch occa-1.1.0 for spurious sys/sysctl.h
  t568-operator: fix input order and make test handle nan; skip on broken backends
  ci: use Noether for CUDA, handle CUDA on Debian CUDA_DIR=/usr
  examples/petsc: fix missing PetscFunctionBegin
  Fluids - Blasius: Some Minor Modifications (#1063)
  ci - newer xsmm for ci
  Icl/magma ntgemm (#1060)
  Fluids - fix blasius test
  Fluids - Some fixes missing from #1039 (#1056)
  Freed orient's array
  fluids: Add STATIC and print-% to makefile
  fluids: Set solution time label for strong stg
  Fluids - Compressible Blasius boundary layer (#1039)
  doc: Update fluids state_var option
  fluids: Switch to StateVar enum
  JIT: free relative path variable after getting absolute path
  magma: free memory used in loading jit kernel source
  fluids: Use newtonian with StateFromQi*_t func pointers
  fluids: Use StateFromQi* for newt boundary QFs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants