Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluids: Decompose SGS DD input and output processing #1223

Merged
merged 3 commits into from Aug 24, 2023
Merged

Fluids: Decompose SGS DD input and output processing #1223

merged 3 commits into from Aug 24, 2023

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented May 25, 2023 •
edited

  • Extract out the SGS DD input and output processing (ie. the rotation to/from S-frame and un-dimensionalizing)
    • This is particularly useful for in situ ML training and for incorporating external inference libraries (rather than computing the neural network manually).

#1203 depends on this PR

@jrwrigh jrwrigh self-assigned this May 25, 2023
@jrwrigh jrwrigh requested a review from jedbrown June 6, 2023 21:36
@jrwrigh jrwrigh mentioned this pull request Jun 5, 2023
Merged
6 tasks
@jrwrigh jrwrigh force-pushed the jrwrigh/decompose_sgs_dd branch 2 times, most recently from 01db47c to e0b5cf6 Compare July 20, 2023 22:11
jeremylt
jeremylt approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@jeremylt jeremylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Not sure if there is someone else we should have review?

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Aug 24, 2023

This looks reasonable to me. Not sure if there is someone else we should have review?

This is mostly a refactor, so I think it's fine. The SmartSim PR should have more eyes on it though.

@jrwrigh jrwrigh merged commit 1b51627 into main Aug 24, 2023
28 checks passed
@jrwrigh jrwrigh deleted the jrwrigh/decompose_sgs_dd branch August 24, 2023 21:08
@jeremylt jeremylt mentioned this pull request Aug 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylt jeremylt jeremylt approved these changes

@jedbrown jedbrown Awaiting requested review from jedbrown

Assignees

@jrwrigh jrwrigh

Labels
1-In Review enhancement examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrwrigh @jeremylt