New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop JiT Guards in Most QF Source #1540
Conversation
Fluids is the only one left - need to check for multiply included files and still guard those Working on parallel changes in Ratel |
Is there any harm in adding |
|
021cc84
to
6298bda
Compare
Do you know if SYCL JiT handles |
7d6be0b
to
2e430ef
Compare
2e430ef
to
56dd355
Compare
Turns out, ROCm doesn't like JiTing |
RIP, not sure about SYCL JIT, but I guess if ROCM doesn't then we probably shouldn't for any of the others. Or (if we really wanted to) we could have |
I'm hesitant to hide too much from the users. I think the way to go for now is to ask users to use |
Is there any |
In this branch |
That's valid, but also we're already implementing what the But it's 6-half-dozen-or-the-other to me. |
The easy part is enabling the pragma for QFunctions. Backend JiT source is harder, but I have an idea |
Ok, "turned on" The way that Basis source is built means this won't work without another backend only interface, but I know what I have to expose for that to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, overall looks good.
f239508
to
c5b0d5b
Compare
c5b0d5b
to
e48d082
Compare
Follow-up on #1534 and #1537, dropping QF source header guards where able