Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluids: Add diffusion to advection problem #1557

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

jrwrigh
Copy link
Collaborator

@jrwrigh jrwrigh commented Apr 10, 2024

Adds diffusion to the advection problem (now making it a "normal" linear advection-diffusion problem). I've tested locally on an over-resolved advecting sine wave and get the analytical solution within 5 digits of accuracy over 2,000 timesteps.

@jrwrigh jrwrigh force-pushed the jrwrigh/diffusion_advection branch from d7df2bb to c7042e9 Compare April 10, 2024 21:19
@jrwrigh jrwrigh requested a review from jeremylt April 10, 2024 21:45
@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 10, 2024

Not sure what's happening with the ROCM error. It's for a completely different fluids tests, and a BPS test failed, so it's probably unreleated.

Copy link
Member

@jeremylt jeremylt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for grins, do we have a cool GIF we can make with this to show off?

@jeremylt
Copy link
Member

There's a failure on re-run, so we need to sort that out before merging

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 10, 2024

Here's a gif for ya. IDK about cool, but it shows the diffusion dampening the higher frequency mode much faster the the lower frequency mode.
out

Edit: I have no idea why it looks so bad in GitHub, but fine locally. I'm guessing I missed a FFMPEG incantation to make avi -> gif not be terrible (because heaven forbid ffmpeg have decent defaults)

@jrwrigh
Copy link
Collaborator Author

jrwrigh commented Apr 10, 2024

There's a failure on re-run, so we need to sort that out before merging

It's non-deterministic both in whether it fails and by the error metric and what backend. Regardless, a third run through passed fine, so this should be fine now.

@jrwrigh jrwrigh merged commit a62415e into main Apr 11, 2024
28 checks passed
@jrwrigh jrwrigh deleted the jrwrigh/diffusion_advection branch April 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants