fix: Correct P0 deprecation #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the PetscOptionsDeprecated caused the P0 option to be ignored for some reason
It will automatically replace the old option with the new option if `PetscOptionsDeprecated` is specified before the new option name.
jrwrigh
force-pushed
the
jrwrigh/fix_blasius_state
branch
from
a36591d
to
f32ddd9
Compare
jrwrigh
force-pushed
the
jrwrigh/fix_blasius_state
branch
from
f32ddd9
to
d63189f
Compare
jeremylt
approved these changes
Apr 29, 2024
Also re-instates the old P0 behavior with regard to the idl_pressure
jrwrigh
force-pushed
the
jrwrigh/fix_blasius_state
branch
from
150c937
to
2249ac9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misuse of
PetscOptionsDeprecatedcaused theP0option to be ignored for some reason.TODO:
PetscOptionsDeprecatedfor the symmetry boundary conditionsP0/pressure_infinityflag. That will (hopefully) help catch these issues more easily.