Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patch from WIP 2.0.0 branch #208

Open
cefn opened this issue Nov 5, 2022 · 0 comments
Open

Remove patch from WIP 2.0.0 branch #208

cefn opened this issue Nov 5, 2022 · 0 comments

Comments

@cefn
Copy link
Owner

cefn commented Nov 5, 2022

Although the patch() signature looked promising to eliminate potentially unpleasant syntax like...

store.write({
  ...store.read(),
  roses:"white"
})

...in favour of

store.patch((state) => ({
  ...state, 
  roses.white
}))

...in fact Typescript features mean that Typescript doesn't force inference (and hence excess property checks) of the Patcher function, without an explicit declaration like this, which is probably worse...

store.patch((state): State => ({
  ...state, 
  roses.white
}))

Consequently unless an alternative can be found, the Store API should have patch() removed before 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant