Js script issue with Cefsharp 96

[Drmsingh]

JS Script working with the cefsharp 95. But after upgraded with cefsharp 96 getting issue with ExecuteScriptAsync when run custom javascript or call the function through native.

• What version of the product are you using?
  -96.0.180

• What architecture x86 or x64?
  x86

• What version of .Net?
  .Net 4.6.1

• On what operating system?
  Win10

• Are you using WinForms, WPF or OffScreen?
  WPF

• What steps will reproduce the problem?
  TRY_JS_MESSAGE_FORMAT = "try {{ {0} }} catch( error ){{ console.log(error) }};";
  message = String.Format(TRY_JS_MESSAGE_FORMAT, message);
  browser.ExecuteScriptAsync(message);

• What is the expected output? What do you see instead?
  should not appears error with the javascript and successfully work.

• Please provide any additional information below.
  Same error with all 96 cefsharp version.

[campersau]

What value does message contain?
This for example works for me:

  var message = "1+1";
  var TRY_JS_MESSAGE_FORMAT = "try {{ {0} }} catch( error ){{ console.log(error) }};";
  message = string.Format(TRY_JS_MESSAGE_FORMAT, message);
  browser.ExecuteScriptAsync(message);

[Drmsingh]

What value does message contain? This for example works for me:

  var message = "1+1";
  var TRY_JS_MESSAGE_FORMAT = "try {{ {0} }} catch( error ){{ console.log(error) }};";
  message = string.Format(TRY_JS_MESSAGE_FORMAT, message);
  browser.ExecuteScriptAsync(message);

Any js function look like below script

message=try { _onForeground() } catch( error ){ console.log(error) };

or

message=try { if (window.onLoad) onLoad("","en_us","","{"winVersion":10}") } catch( error ){ console.log(error) };

[amaitland]

Run your script directly in DevTools and see if you get the same behaviour.

https://github.com/cefsharp/CefSharp/wiki/Trouble-Shooting#javascript-debugging

Converting to discussion as this is unlikely a bug in CefSharp. Most likely a result of a change in Chromium.

[chendemand]

I use Cefsharp 95 , use this , chromiumWebBrowser1.ExecuteScriptAsync("document.getElementsByTagName('input')[2].click();"); can work. But use Cefsharp 96 don't work it .

[chendemand]

than i use this ==>chromiumWebBrowser1.ExecuteScriptAsync("(function(){document.getElementsByTagName('input')[2].click();})"); ==> is ok @Drmsingh

[amaitland]

chromiumWebBrowser1.ExecuteScriptAsync("document.getElementsByTagName('input')[2].click();"); can work. But use Cefsharp 96 don't work it .

Thanks for the example. That is indeed a bug in CefSharp.

[Drmsingh]

than i use this ==>chromiumWebBrowser1.ExecuteScriptAsync("(function(){document.getElementsByTagName('input')[2].click();})"); ==> is ok @Drmsingh

I have tried but not working for me. One more thing, when not passing function, just passing the js statement before function look like.. message=try { if (window.onLoad) onLoad("","en_us","","{"winVersion":10}") } catch( error ){ console.log(error) }; then?

[campersau]

This commit changed the extension method this parameter

b72d413#diff-365a64085d19bad852c00c0769656b9a2deb678b74ac09807fe102e1f9787b72R501

so when calling IWebBrowser.ExecuteScriptAsync it now chooses this method

CefSharp/CefSharp/WebBrowserExtensions.cs

Line 472 in 604e957

public static void ExecuteScriptAsync(this IWebBrowser browser, string methodName, params object[] args)

which appends (); as it expects just a method name.

So casting IWebBrowser to IChromiumWebBrowserBase works:

((IChromiumWebBrowserBase)browser).ExecuteScriptAsync(message);

Possible fix: a6b14b7

[amaitland]

I don't recommend using any such workaround as they will likely break when this is fixed.

Using the following should work as expected and is functionality the same (JavaScript is executed on the main frame by default).

chromiumWebBrowser.GetMainFrame().ExecuteJavaScriptAsync(script); 

[amaitland]

Unfortunately I cannot reopen the original issue so #3944 will now be used to track this issue.