Skip to content
This repository has been archived by the owner on Jun 18, 2023. It is now read-only.

CCDCesque: model end positioning can be wrong #72

Closed
ceholden opened this issue Dec 8, 2015 · 0 comments
Closed

CCDCesque: model end positioning can be wrong #72

ceholden opened this issue Dec 8, 2015 · 0 comments
Labels
Milestone

Comments

@ceholden
Copy link
Owner

ceholden commented Dec 8, 2015

In v0.5.5 and previous versions, if timeseries monitoring in CCDCesque ended on an observation that was screened as noise in the monitoring period (using remove_noise=True), the last record's end attribute would be recorded as the date of this screened observation.

Nobody seems to have noticed before because it's only a 8-16 day offset when using Landsat data and CCDCesque models end on the last observation before the consecutive check so one more observation behind this number wasn't noticeable. I only found it when trying to validate some performance optimizations occuring within v0.6.0 (see #70).

This bug was resolved in the optimization implementations (per #70), specifically in 31e21f9

@ceholden ceholden added the bug label Dec 8, 2015
@ceholden ceholden added this to the v0.6.0 milestone Dec 8, 2015
@ceholden ceholden closed this as completed Dec 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant