Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Brave 81.1.8.86 #15

Closed
TirOFlanc opened this issue Apr 30, 2020 · 7 comments
Closed

Issue with Brave 81.1.8.86 #15

TirOFlanc opened this issue Apr 30, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@TirOFlanc
Copy link

TirOFlanc commented Apr 30, 2020

Hello,

There is a problem with the latest version of Brave to disable the alert for extensions in developer mode.

C:\ChromeDevExtWarningPatcher.exe --customPath "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application" --disableGroups 1,2 --noWait

Found pattern offset at 73424958
Source byte of patch at 22: 4
73424980 => 255
Found pattern offset at 73424958
Source byte of patch at 35: 8
73424993 => 255
Couldn't find offset for a patch Remove Crash Warning
Error trying to patch C:\Program Files (x86)\BraveSoftware\Brave-Browser\Applica
tion\81.1.8.86\chrome.dll

Made with version 3.6 of ChromeDevExtWarningPatcher

Have a nice day :)

@Ceiridge
Copy link
Owner

Ceiridge commented Apr 30, 2020

You've enabled "Remove Crash Warning".
Tell me what you can read when you hover over the patch with your mouse in the patcher gui.

@Ceiridge
Copy link
Owner

I just saw that you were using the command line. There is a new patch group 3 that is "Remove Crash Warning".
I should add an argument --onlyGroups, because it is affected by new patches in the patterns.xml file.

@TirOFlanc
Copy link
Author

Oh yes !
"This patch removes the warning after a chromium crash (doesn't work for some browsers like Brave)"
Next time, I'll think about checking the GUI.
So I need to add 3 to --disableGroups or just wait your next version with the new arg ?

@Ceiridge
Copy link
Owner

You can wait for the new version with the new arg, because it doesn't make sense to always break the tool after a new update.
It should be released in 15 minutes

@TirOFlanc
Copy link
Author

Oh, it's not that hurry but ok, you're so responsive. ^^'

@Ceiridge Ceiridge added the bug Something isn't working label Apr 30, 2020
@Ceiridge Ceiridge self-assigned this Apr 30, 2020
@TirOFlanc
Copy link
Author

It's Works fine !

For people who just want to disable the brave's dev ext warning :

ChromeDevExtWarningPatcher.exe --customPath "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application" --groups 0 --noWait

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants