Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple elements per material #182

Closed
4 tasks done
sethrj opened this issue Mar 15, 2021 · 3 comments · Fixed by #326 or #440
Closed
4 tasks done

Support multiple elements per material #182

sethrj opened this issue Mar 15, 2021 · 3 comments · Fixed by #326 or #440
Assignees
Labels
physics Particles, processes, and stepping algorithms
Projects
Milestone

Comments

@sethrj
Copy link
Member

sethrj commented Mar 15, 2021

Currently we're using a simplification of allowing only one element per material, so that we don't have to calculate/tabulate/sample elemental cross sections in a given material.

Our CERN collaborators informed us that many of the Geant4 physics models actually use tabulated-by-element cross section data rather than calculating on the fly, so we should be able to build element sampling (in most cases) into the process/model selection kernel.

  • Export tabulated micro cross sections from Geant4 (Import element microscopic cross sections #326 )
  • Preprocess micros into CDFs/alias tables during Celeritas setup
  • Sample elements after model selection in the "discrete" kernel (for those that have tabulated cross sections)
  • On-the-fly element selection for OTF processes (photoelectric, annihilation) inside the interaction kernels
@sethrj sethrj added physics Particles, processes, and stepping algorithms material labels Mar 15, 2021
@sethrj sethrj added this to the Y2 Goals milestone Mar 15, 2021
@sethrj sethrj added this to To do in v0.1.0 via automation Mar 15, 2021
@sethrj
Copy link
Member Author

sethrj commented Mar 18, 2021

See also #60 where we discussed the first aspects of element/process cross section calculation. I probably should have read it over more carefully before closing it and opening this guy 🙄

@sethrj sethrj modified the milestones: Y2Q4 Goals, Y2Q3 Goals Sep 23, 2021
@stognini stognini linked a pull request Dec 14, 2021 that will close this issue
@sethrj sethrj moved this from To do to In progress in v0.1.0 Dec 16, 2021
v0.1.0 automation moved this from In progress to Done Dec 17, 2021
@sethrj
Copy link
Member Author

sethrj commented Apr 29, 2022

This was closed by mistake 😬 still work to be done.

@sethrj sethrj reopened this Apr 29, 2022
v0.1.0 automation moved this from Done to In progress Apr 29, 2022
@sethrj sethrj removed this from In progress in v0.1.0 Apr 29, 2022
@sethrj sethrj added this to To Do in v0.1.1 via automation Apr 29, 2022
@sethrj sethrj moved this from To Do to In Progress in v0.1.1 Apr 29, 2022
@sethrj sethrj assigned amandalund and stognini and unassigned stognini May 8, 2022
@sethrj
Copy link
Member Author

sethrj commented Jul 20, 2022

Closed by #440, thanks @amandalund !

@sethrj sethrj closed this as completed Jul 20, 2022
v0.1.1 automation moved this from In Progress to Done Jul 20, 2022
@sethrj sethrj linked a pull request Jul 20, 2022 that will close this issue
@sethrj sethrj removed the material label Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics Particles, processes, and stepping algorithms
Projects
No open projects
3 participants