Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GeantGeoConverter for G4ReflectedSolid #750

Closed
whokion opened this issue May 9, 2023 · 2 comments · Fixed by #761
Closed

Extend GeantGeoConverter for G4ReflectedSolid #750

whokion opened this issue May 9, 2023 · 2 comments · Fixed by #761
Assignees
Labels
bug Something isn't working

Comments

@whokion
Copy link
Contributor

whokion commented May 9, 2023

While running demo-geant-integration with cms-run3.gdml, there are in-memory GeantGeoConverter failures for G4ReflectedSolid,

internal assertion failed: SoftEqual{0.01}(v1,v2)

from GeantGeoConverter.cc.

By-passing the assert, hit the next assertion in the downstream at

src/celeritas/mat/MaterialTrackView.hh:102:
celeritas: internal assertion failed: other.material_id < params_.materials.size()

See the log file, run3-cms-test.log using VecGeom v1.2.2 (same behavior with CMSSW+celeritas+VecGeom v1.2.1)

@whokion whokion added the bug Something isn't working label May 9, 2023
@sethrj
Copy link
Member

sethrj commented May 9, 2023

Thanks @whokion . The failure is because:

/work1/celeritas/syjun/celeritas/src/celeritas/src/celeritas/geo/GeoMaterialParams.cc:157: warning: Some geometry volumes do not have known material IDs: world_volume@0x7f7110475c60, cms_OCMS@0x7f7110475bc0, cms_CMSE@0x7f7110475b20, cmsextent_CMStoZDC@0x7f7110474c20, cmsextent_ZDCtoFP4201@0x7f7110474cc0 ....

so next I can try to figure out why the volume names aren't being found correctly.

@sethrj
Copy link
Member

sethrj commented May 10, 2023

OK also just a note to self: the G4ReflectedSolid is created via G4ReflectionFactory in G4GDMLReadStructure::PhysvolRead by inspecting the transformation matrix to see if it has a negative scale factor (e.g., z=-1 scaling).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants