Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support django email backends #15

Closed
matclayton opened this issue Sep 17, 2010 · 6 comments
Closed

Doesn't support django email backends #15

matclayton opened this issue Sep 17, 2010 · 6 comments

Comments

@matclayton
Copy link

For error sending, when a local smtp isn't available this would be useful

@ask
Copy link
Contributor

ask commented Oct 1, 2010

Could you give me an example of how this should work?

@matclayton
Copy link
Author

Django by default provides an email sending system, with pluggable backends. This allows app developers to configure different methods of sending email, which is especially useful for AppEngine and various cloud providers.

What is probably a far better solution however is to tie into the new django logging system

http://code.djangoproject.com/ticket/12012

I believe this is going in trunk next week, and django will use it as the default logging mechanic for 500's and other errors, maybe celery should use it instead of emailing errors, allowing the developer to choose the desired method of reporting.

@leknarf
Copy link

leknarf commented Oct 10, 2010

I'd like to see support for the django email backends as well. Custom defined backends are useful for AppEngine, like matclayton said, but the django provided console and file backends (which write out emails to stdout or disk) are convenient for development.

Django-celery could leverage the django infrastructure by using the mail_admin() function in django.core.mail instead of the custom mail_admin() function in celery.utils.mail. The two already have the same signature, so using the django version when available should be straightforward.

Using the new django logging system is a better forward looking solution, but that would be a larger change.

@ask
Copy link
Contributor

ask commented Nov 18, 2010

This is actually in place now (part of 2.1.2), does it work well for everybody?

@matclayton
Copy link
Author

Cheers for merging it, have it on production now, and its fantastic.

@ask
Copy link
Contributor

ask commented Nov 24, 2010

Great! Closing now then, thanks to the awesome mixcloud guys.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants