Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to signing over all relevant square sizes when creating a WirePayForMessage #239

Closed
evan-forbes opened this issue Mar 10, 2022 · 2 comments · Fixed by #441
Closed
Assignees

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Mar 10, 2022

Currently we require a user to select which square sizes they want to sign over. This is a hostile UX, as the user must have extraneous knowledge on the data square, malleated transactions, and the non-interactive default rules to know which square sizes to sign over. For most cases, the user will likely want to sign all relevant square sizes.

as pointed out in #236, this does not mean that they have to sign over all square sizes

if a message can fit on a single row of square size x, then a valid commitment for square size x is valid for all square sizes >= x.

Also, they don't have to sign over square sizes that don't have enough shares to include their message + MsgPayForMessage transaction.

@toanngosy
Copy link
Contributor

Hi @evan-forbes, can I work on this?

@evan-forbes
Copy link
Member Author

certainly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants