Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Blockchain reactor v2 #13

Closed
liamsi opened this issue Apr 12, 2020 · 0 comments · Fixed by #53
Closed

Switch to Blockchain reactor v2 #13

liamsi opened this issue Apr 12, 2020 · 0 comments · Fixed by #53
Labels
T:tendermint Type: upstream tendermint changes we want

Comments

@liamsi
Copy link
Member

liamsi commented Apr 12, 2020

The original blockchain reactor (v0) is a mess and hard to reason about (e.g. look at this: https://github.com/tendermint/tendermint/blob/ef56e6661121a7f8d054868689707cd817f27b24/blockchain/v0/reactor.go#L214-L366).

There has been quite some effort to refactor the current reactor and there are plans to switch to v2:
tendermint/tendermint#4595

The main blocker seems to be that the latest version isn't well tested. IMO we should start using the lastest version as soon as the integration tests work at least (see: tendermint/tendermint#4640). It will also make changes for immediate state execution simpler (ref #3).

@liamsi liamsi added the T:tendermint Type: upstream tendermint changes we want label Apr 12, 2020
@liamsi liamsi closed this as completed in #53 Sep 8, 2020
@liamsi liamsi added this to To do in LazyLedger MVP via automation Mar 16, 2021
@liamsi liamsi moved this from To do to Done in LazyLedger MVP Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:tendermint Type: upstream tendermint changes we want
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant