Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync | p2p: Collect more information about invalid network head in metric when rejecting it #141

Open
renaynay opened this issue Jan 8, 2024 · 2 comments
Labels
good first issue Good for newcomers p2p

Comments

@renaynay
Copy link
Member

renaynay commented Jan 8, 2024

Collect information about peer ID here when recording rejected msg from header-sub (such as the peerID and error message) (and possibly also record the height of the rejected header).

In syncer, record height + reason for rejection here

@Wondertan
Copy link
Member

Wondertan commented Jan 8, 2024

Metrics require listing and coding out all the possible rejection reasons, and they can't be arbitrary. These reasons are implementation-specific, and the Subscriber cannot know all of them internally. I think we need to have this as part of the Syncer metrics

@renaynay renaynay changed the title p2p: Collect more information about peer and rejection reason in metric when rejecting message from header-sub sync: Collect more information about invalid network head in metric when discarding an incoming network head Jan 8, 2024
@renaynay renaynay changed the title sync: Collect more information about invalid network head in metric when discarding an incoming network head sync | p2p: Collect more information about invalid network head in metric when rejecting it Jan 8, 2024
@renaynay
Copy link
Member Author

renaynay commented Jan 8, 2024

@Wondertan changed description now - I think it should be recorded in both places as what I want to see is peerID + height of bad header that is getting rejected. We can then correlate it to height + reason from sync metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers p2p
Projects
None yet
Development

No branches or pull requests

2 participants