store: drop Init function

[cristaloleg]

Looks like this function is just a test helper (used only in 1 place BTW). But also it looks orthogonal to the Store interface which already contains Init method.

I'm proposing to drop this function in favour of NewStoreWithHead which does the initialization.

[cristaloleg]

The only thing is that we've 1 usage in celestia-node see nodebuilder/header/constructors.go but this can be easily addressed.

[cristaloleg]

After a deeper look looks like we do not use Store.Init properly. By example in celestia-node in cmd/cel-shed/header.go we initialize store manually however Init func can do the same.

I think this issues should be extended to something: store: drop Init function and use Store.Init where appropriate.

WDYT ?

[Wondertan]

Why not to keep this function for reuse purposes? We already use in one place and as you mentioned we could use it one more place?

[cristaloleg]

Yep, after hour of jumping back and forth all over the code looks like there is nothing we can do. We have a way to initialize store via header, via height. Better to leave it as it's for now.

Closing.