fix(store): properly update heightSub height #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
requested review from
tzdybal,
renaynay,
Wondertan,
vgonkivs,
gupadhyaya,
walldiss and
ramin
as code owners
cristaloleg
force-pushed
the
store/fix-heighsub-when-gaps
branch
from
378c15e
to
9e25e4a
Compare
cristaloleg
commented
Jun 25, 2024
| from, to := headers[0].Height(), headers[ln-1].Height() | ||
| if height+1 != from && height != 0 { // height != 0 is needed to enable init from any height and not only 1 |
There was a problem hiding this comment.
Took from #197
Basically this was the last thing that was requiring adjacency in store.
|
See #207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
PR #186 introduced a bug which resulted in an incorrect height reported by
heightSub.heightSub.Heightshould be updated only when all height below the current one were observed.Fixes #201 (+ test from #197)