Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fractional part of julian date can't be edited correct in Qt #76

Closed
GottfriedSp opened this issue Jul 12, 2018 · 3 comments · Fixed by #2101
Closed

fractional part of julian date can't be edited correct in Qt #76

GottfriedSp opened this issue Jul 12, 2018 · 3 comments · Fixed by #2101
Labels
bug Something isn't working qt Specific to Qt frontend

Comments

@GottfriedSp
Copy link
Contributor

The fractional part cant be edited.
Example: when removing the fractional part and then set the value 2452251,2 it is automatic filled with 2452251,2000000002 and cant be edited from this point

@375gnu
Copy link
Member

375gnu commented Jul 13, 2018

This is due to how floating point numbers are implemented in hardware, we can't fix it.

@GottfriedSp
Copy link
Contributor Author

Possible implementation is not to change the time and date during editing julian date.
When QLineEdit lost its focus, it can calculate the date and time which also updated the juliandate.

@375gnu 375gnu added this to To do in Release 1.7.0 Apr 23, 2019
@375gnu 375gnu added qt Specific to Qt frontend bug Something isn't working labels Aug 23, 2019
@ajtribick
Copy link
Collaborator

Editing should be fixed now since the update signals are no longer being bounced back-and-forth between the time component boxes and the JD entry, and the controls in question now use spinboxes rather than line edits.

The values still get adjusted to something slightly off, might be worth reducing the number of decimal places to, e.g. 6 (which still gives ~1/10 second precision)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qt Specific to Qt frontend
Projects
Release 1.7.0
  
To do
Development

Successfully merging a pull request may close this issue.

3 participants